[native]Set promise out of ExchangeQueue lock (#4111)#19101
Merged
xiaoxmeng merged 1 commit intoprestodb:masterfrom Feb 23, 2023
Merged
[native]Set promise out of ExchangeQueue lock (#4111)#19101xiaoxmeng merged 1 commit intoprestodb:masterfrom
xiaoxmeng merged 1 commit intoprestodb:masterfrom
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D43504994 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 22, 2023
Summary: X-link: prestodb/presto#19101 Set promise out of ExchangeQueue lock to avoid potential deadlock caused by the inline executed future continuation callback Pull Request resolved: facebookincubator#4111 Reviewed By: Yuhta Differential Revision: D43504994 Pulled By: xiaoxmeng fbshipit-source-id: 89436270de409eea528bda434638263b72b7feb8
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D43504994 |
xiaoxmeng
force-pushed
the
export-D43504994
branch
from
fc8f283 to
a56f7a8
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D43504994 |
xiaoxmeng
force-pushed
the
export-D43504994
branch
from
a56f7a8 to
10dcc10
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Feb 22, 2023
Summary: X-link: prestodb/presto#19101 Set promise out of ExchangeQueue lock to avoid potential deadlock caused by the inline executed future continuation callback Pull Request resolved: facebookincubator#4111 Reviewed By: Yuhta Differential Revision: D43504994 Pulled By: xiaoxmeng fbshipit-source-id: 46c9839307e8c97a238cb1ecc7d74c0c15dcfc5a
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Feb 23, 2023
Summary: X-link: prestodb/presto#19101 Set promise out of ExchangeQueue lock to avoid potential deadlock caused by the inline executed future continuation callback Pull Request resolved: #4111 Reviewed By: Yuhta Differential Revision: D43504994 Pulled By: xiaoxmeng fbshipit-source-id: 82c960f2789ac0fd7509300c24b2d842fe8ca007
xiaoxmeng
changed the title
xiaoxmeng
force-pushed
the
export-D43504994
branch
from
10dcc10 to
6d80168
Compare
mshang816
approved these changes
Feb 23, 2023
Contributor
mshang816
left a comment
mshang816
left a comment
There was a problem hiding this comment.
LGTM. The diff was landed successfully so we can merge this one after all the tests are green.
xiaoxmeng
force-pushed
the
export-D43504994
branch
2 times, most recently
from
3fd2488 to
2cdff1b
Compare
xiaoxmeng
force-pushed
the
export-D43504994
branch
from
2cdff1b to
0b77ab7
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback
X-link: facebookincubator/velox#4111
Reviewed By: Yuhta
Differential Revision: D43504994
Pulled By: xiaoxmeng