Skip to content

Set promise out of ExchangeQueue lock#4111

Closed
xiaoxmeng wants to merge 1 commit intofacebookincubator:mainfrom
xiaoxmeng:promise
Closed

Set promise out of ExchangeQueue lock#4111
xiaoxmeng wants to merge 1 commit intofacebookincubator:mainfrom
xiaoxmeng:promise

Conversation

@xiaoxmeng
Copy link
Contributor

Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 27aad60
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/63f6a5031ca1f10008c21e2b

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2023
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xiaoxmeng xiaoxmeng requested a review from Yuhta February 22, 2023 18:43
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request Feb 22, 2023
Summary:
Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback

Pull Request resolved: facebookincubator#4111

Differential Revision: D43504994

Pulled By: xiaoxmeng

fbshipit-source-id: 516b4cfd28576f4d6736d10a32461444ae55fa95
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43504994

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request Feb 22, 2023
Summary:
Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback

Pull Request resolved: facebookincubator#4111

Differential Revision: D43504994

Pulled By: xiaoxmeng

fbshipit-source-id: 414d4e4263b9044dac4693b9d521fb7bf012a2c5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43504994

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request Feb 22, 2023
Summary:
Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback

Pull Request resolved: facebookincubator#4111

Reviewed By: Yuhta

Differential Revision: D43504994

Pulled By: xiaoxmeng

fbshipit-source-id: 82c11df0ace779a7e96bb7f360b9a4897ffb90f8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43504994

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request Feb 22, 2023
Summary:
X-link: prestodb/presto#19101

Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback

Pull Request resolved: facebookincubator#4111

Reviewed By: Yuhta

Differential Revision: D43504994

Pulled By: xiaoxmeng

fbshipit-source-id: 89436270de409eea528bda434638263b72b7feb8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43504994

Summary:
X-link: prestodb/presto#19101

Set promise out of ExchangeQueue lock to avoid potential deadlock
caused by the inline executed future continuation callback

Pull Request resolved: facebookincubator#4111

Reviewed By: Yuhta

Differential Revision: D43504994

Pulled By: xiaoxmeng

fbshipit-source-id: 46c9839307e8c97a238cb1ecc7d74c0c15dcfc5a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43504994

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 92fbfb9.

@xiaoxmeng xiaoxmeng deleted the promise branch February 23, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants