Skip to content

[native] Adding partial support for EquatableValueSet filter. #18841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Dec 25, 2022
Merged

[native] Adding partial support for EquatableValueSet filter. #18841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,8 +614,15 @@ std::unique_ptr<common::Filter> toFilter(
auto equatableValueSet =
std::dynamic_pointer_cast<protocol::EquatableValueSet>(
domain.values)) {
if (equatableValueSet->entries.empty()) {
if (nullAllowed) {
return std::make_unique<common::IsNull>();
} else {
return std::make_unique<common::IsNotNull>();
}
}
VELOX_UNSUPPORTED(
"EquatableValueSet to Velox filter conversion is not supported yet.");
"EquatableValueSet (with non-empty entries) to Velox filter conversion is not supported yet.");
} else if (
auto allOrNoneValueSet =
std::dynamic_pointer_cast<protocol::AllOrNoneValueSet>(
Expand Down
4 changes: 4 additions & 0 deletions presto-native-execution/src/test/java/com/facebook/presto/nativeworker/TestHiveQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,10 @@ public void testIsNullIsNotNull()
{
assertQuery("SELECT count(*) FROM orders where clerk is not null");
assertQuery("SELECT count(*) FROM orders where clerk is null");
assertQuery("select count(*) from orders_ex where quantities is null");
assertQuery("select count(*) from orders_ex where quantities is not null");
assertQuery("select count(*) from orders_ex where quantity_by_linenumber is null");
assertQuery("select count(*) from orders_ex where quantity_by_linenumber is not null");
}

@Test
Expand Down