Skip to content

[native] Adding partial support for EquatableValueSet filter. #18841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amitkdutta merged 1 commit into from
Dec 25, 2022
Merged

[native] Adding partial support for EquatableValueSet filter. #18841

amitkdutta merged 1 commit into from
Dec 25, 2022

Conversation

@amitkdutta
Copy link
Contributor

@amitkdutta amitkdutta commented Dec 23, 2022

Adding support for EquatableValueSet when entries list is empty. Will add full support once we figure out how to use non-empty entries list and whitelist flag.

@amitkdutta amitkdutta requested a review from a team as a code owner December 23, 2022 21:51
@amitkdutta amitkdutta force-pushed the null_filter_map_array branch from e24ac41 to 1ad6cbd Compare December 23, 2022 21:55
@amitkdutta
Copy link
Contributor Author

amitkdutta commented Dec 24, 2022

The unit test failure is in TaskManagerTest.outOfQueryUserMemory, it has a segfault


5: [ RUN      ] TaskManagerTest.outOfQueryUserMemory
5: * Aborted at 1671837265 (Unix time, try 'date -d @1671837265') *
5: * Signal 11 (SIGSEGV) (0x18) received by PID 3865 (pthread TID 0x7f56c356f780) (linux TID 3865) (code: address not mapped to object), stack trace: *
5: (error retrieving stack trace)

@xiaoxmeng any thoughts? take a look when you get a chance. CC: @mbasmanova @spershin

spershin
spershin approved these changes Dec 25, 2022
View reviewed changes
Copy link
Contributor

@spershin spershin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks!

@amitkdutta
Copy link
Contributor Author

amitkdutta commented Dec 25, 2022

Memory test is fixed in
#18842

@amitkdutta amitkdutta merged commit 78f7a7c into prestodb:master Dec 25, 2022
@wanglinsong wanglinsong mentioned this pull request Jan 12, 2023
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spershin spershin spershin approved these changes

@mbasmanova mbasmanova Awaiting requested review from mbasmanova

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amitkdutta @spershin