Disable S3 Select pushdown when the query does not filter data #18778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pettyjamesm please have a look when you find the time |
dnanuti
force-pushed
the
select-pushdown-optimisation
branch
2 times, most recently
from
834eecd to
cbee0ea
Compare
pettyjamesm
reviewed
Dec 7, 2022
presto-hive/src/main/java/com/facebook/presto/hive/s3select/S3SelectRecordCursorProvider.java
Outdated
Show resolved
Hide resolved
pettyjamesm
reviewed
Dec 7, 2022
presto-hive/src/main/java/com/facebook/presto/hive/s3select/S3SelectRecordCursorProvider.java
Outdated
Show resolved
Hide resolved
dnanuti
force-pushed
the
select-pushdown-optimisation
branch
from
89a2f8c to
f074a9a
Compare
S3 Select pushdown improves queries performance by reducing the data processed on the client side and it is effective when the query pushed down to Select is filtering out a significant portion of the data. This commit disables Select pushdown when the query does not have a predicate or projection. In these cases using GET is both cheaper and faster.
dnanuti
force-pushed
the
select-pushdown-optimisation
branch
from
f074a9a to
86348b2
Compare
fuatbasik
approved these changes
Dec 8, 2022
pettyjamesm
approved these changes
Dec 8, 2022
Contributor
pettyjamesm
left a comment
pettyjamesm
left a comment
There was a problem hiding this comment.
LGTM, @rschlussel - anyone else you know of that should take a look before merging?
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 Select pushdown improves queries performance by reducing the data on the wire and it is the most effective when the query pushed down to Select is filtering out a significant portion of the data. This commit disables Select pushdown when the query does not have a predicate or projection. In these cases using GET is both cheaper and faster.
Test plan - (Please fill in how you tested your changes)
Unit tests
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.