Make open writers limit configurable in iceberg connector#17771
Merged
NikhilCollooru merged 2 commits intoprestodb:masterfrom May 19, 2022
Merged
Make open writers limit configurable in iceberg connector#17771NikhilCollooru merged 2 commits intoprestodb:masterfrom
NikhilCollooru merged 2 commits intoprestodb:masterfrom
Conversation
NikhilCollooru
approved these changes
May 17, 2022
kewang1024
approved these changes
May 18, 2022
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSinkProvider.java
Outdated
Show resolved
Hide resolved
kewang1024
reviewed
May 18, 2022
Collaborator
kewang1024
left a comment
kewang1024
left a comment
There was a problem hiding this comment.
For the second commit, can we improve the commit message to "Add Iceberg configuration properties in docs"
v-jizhang
force-pushed
the
iceberg-open-writers-conf
branch
from
9f35605 to
f85079d
Compare
Contributor
NikhilCollooru
left a comment
NikhilCollooru
left a comment
There was a problem hiding this comment.
Please change the 2nd commit title to "Add Iceberg configuration property to docs"
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSinkProvider.java
Outdated
Show resolved
Hide resolved
v-jizhang
force-pushed
the
iceberg-open-writers-conf
branch
from
cf75aaa to
760ab72
Compare
Cherry-pick of Trino trinodb/trino#6684 Co-authored-by: Akshay Rai <akrai@linkedin.com>
Cherry-pick of trinodb/trino#7200 Co-authored-by: Amit Singh <amitds1997@gmail.com>
v-jizhang
force-pushed
the
iceberg-open-writers-conf
branch
from
54b2cd9 to
e8878aa
Compare
Contributor
Author
Changed. Thank you. |
Contributor
|
To wat value we can increase the parameter value ? For hive ? I see page of position count of 4096 is getting processed any relation of this and parameter defined? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of Trino trinodb/trino#6684
Addresses trinodb/trino#6650.
Co-authored-by: Akshay Rai akrai@linkedin.com