Add Iceberg configuration properties in docs#7200
Add Iceberg configuration properties in docs#7200phd3 merged 1 commit intotrinodb:masterfrom amitds1997:iceberg-docs
Conversation
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
Looks like a good improvement.
(In future, it'd be worth making the configuration section more exhaustive, but that might be difficult to do without making a more fundamental change of isolating/renaming some hive configs.)
| Iceberg configuration properties | ||
| -------------------------------- | ||
|
|
||
| ================================================== ============================================================ ============ |
There was a problem hiding this comment.
Convert this to a list table please
There was a problem hiding this comment.
I assume this just means adding them as different sub-sections. Let me know if it's otherwise.
There was a problem hiding this comment.
Oh .. sorry.. here is an example of a list table -
Cache Configuration Parameters
in
https://github.com/trinodb/trino/blob/master/docs/src/main/sphinx/connector/hive-caching.rst
There was a problem hiding this comment.
Done. Can you review this once again?
| -------------------------------- | ||
|
|
||
| ================================================== ============================================================ ============ | ||
| Property Name Description Default |
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
A few small changes requested..
| Possible values are ``PARQUET``, or ``ORC``. | ||
|
|
||
| ``iceberg.compression-codec`` The compression codec to use when writing files. ``GZIP`` | ||
| Possible values are ``NONE``, ``SNAPPY``, ``LZ4``, |
There was a problem hiding this comment.
Maybe better to have the values in a bullet list
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
One last mini tweak.. but essentially done. Awesome job.
There was a problem hiding this comment.
Remove the bolding of the title .. if we want that as a general thing we do it across all tables or just update the CSS
There was a problem hiding this comment.
Understood! Done 👍🏽
There was a problem hiding this comment.
this is purely relevant for writing, I'd revert to that wording.
There was a problem hiding this comment.
Nice catch, somewhere when rewriting, I must have rewritten this. Done
Added configurable properties for Iceberg connectors. Have purposefully left out `iceberg.use-file-size-from-metadata` since it has been marked deprecated.
|
Thanks @amitds1997 ! |
Cherry-pick of trinodb/trino#7200 Co-authored-by: Amit Singh <amitds1997@gmail.com>
Cherry-pick of trinodb/trino#7200 Co-authored-by: Amit Singh <amitds1997@gmail.com>
3 participants
Added configurable properties for Iceberg connectors. Have purposefully left out
iceberg.use-file-size-from-metadatasince it has been marked deprecated.