Skip to content

Make sure that quoted identifiers remain quoted in formatter #17406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-jizhang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure that quoted identifiers remain quoted in formatter #17406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presto-parser/src/main/java/com/facebook/presto/sql/SqlFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,7 @@ protected Void visitInsert(Insert node, Integer indent)
public Void visitSetSession(SetSession node, Integer context)
{
builder.append("SET SESSION ")
.append(node.getName())
.append(formatName(node.getName()))
.append(" = ")
.append(formatExpression(node.getValue(), parameters));

Expand All @@ -1256,7 +1256,7 @@ public Void visitSetSession(SetSession node, Integer context)
public Void visitResetSession(ResetSession node, Integer context)
{
builder.append("RESET SESSION ")
.append(node.getName());
.append(formatName(node.getName()));

return null;
}
Expand Down
13 changes: 13 additions & 0 deletions presto-parser/src/test/java/com/facebook/presto/sql/parser/TestSqlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,19 @@ public void testResetSession()
assertStatement("RESET SESSION foo", new ResetSession(QualifiedName.of("foo")));
}

@Test
public void testSessionIdentifiers()
{
assertStatement("SET SESSION \"foo-bar\".baz = 'x'",
new SetSession(QualifiedName.of("foo-bar", "baz"), new StringLiteral("x")));
assertInvalidStatement("SET SESSION foo-bar.name = 'value'",
"mismatched input '-'. Expecting: '.', '='");
assertStatement("RESET SESSION \"foo-bar\".baz",
new ResetSession(QualifiedName.of("foo-bar", "baz")));
assertInvalidStatement("RESET SESSION foo-bar.name",
"mismatched input '-'. Expecting: '.', <EOF>");
}

@Test
public void testShowSession()
{
Expand Down