Make sure that quoted identifiers remain quoted in formatter#17406
Open
v-jizhang wants to merge 1 commit intoprestodb:masterfrom
Open
Make sure that quoted identifiers remain quoted in formatter#17406v-jizhang wants to merge 1 commit intoprestodb:masterfrom
v-jizhang wants to merge 1 commit intoprestodb:masterfrom
Conversation
Cherry-pick of trinodb/trino#11171 The SqlFormatter effectively drops quotes from the quoted identifiers when formatting 'SET SESSION' statement. This causes valid queries to fail: e.g. SET SESSION "name-suffix".property = 'value' PrestoException: Formatted query does not parse even when identifier (name-suffix) is quoted. Follow up prestodb#17186 Co-authored-by: Sergey Melnychuk <sergey.melnychuk@starburstdata.com>
elharo
approved these changes
Sep 29, 2024
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
This looks good, but the CI hasn't fired. Can someone kick it off? Or maybe rebasing to master and pushing would kick ti off?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#11171
The SqlFormatter effectively drops quotes from the quoted identifiers
when formatting 'SET SESSION' statement.
This causes valid queries to fail: e.g. SET SESSION
"name-suffix".property = 'value' PrestoException: Formatted query does
not parse even when identifier (name-suffix) is quoted.
Follow up #17186
Co-authored-by: Sergey Melnychuk sergey.melnychuk@starburstdata.com
Test plan - Added a test