Add configs to control aggregate/Window/Orderby Spilling#16581
Conversation
There was a problem hiding this comment.
change this and orderby to check isAggregationSpillEnabled() instead of isSpillEnabled(). (or alternatively, just remove the isSpillEnabled check for both since we check all three properties anyway when build the aggregation operator)
There was a problem hiding this comment.
don't need to pass in spillEnabled anymore since aggregationSpillEnabled includes a check for spillEnabled.
rschlussel
left a comment
There was a problem hiding this comment.
Can you also add tests for window and order by in TestSpilledWindowQueries and TestSpilledOrderByQueries
|
One more thing. Can you add documentation to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties.rst#spilling-properties |
ddb0bd9 to
e028381
Compare
`spill_enabled` session property enable spills for all operators. Currently, there is no way to control aggergation/Window/Orderby spilling explicitly. This PR adds configs to control these 3 operators spilling.
e028381 to
1fe34c4
Compare
|
@rschlussel : Addressed all the comments. |
| return planGroupByAggregation( | ||
| node, | ||
| source, | ||
| spillEnabled, |
There was a problem hiding this comment.
can remove the spillEnabled variable now since its unused
There was a problem hiding this comment.
@rschlussel : This variable is already removed. We now only pass isAggregationSpillEnabled flag along with isDistinctAggregationSpillEnabled and isOrderByAggregationSpillEnabled.
There was a problem hiding this comment.
sorry got it confused due to collapsed code in github. Looks good.
spill_enabledsession property enable spills for all operators. Currently, there isno way to control aggregation/Window/Orderby spilling explicitly. This PR adds configs to
control these 3 operators spilling.
Test plan - Unit tests