Add config/session property to control aggregate Spilling#16578
Closed
pgupta2 wants to merge 1 commit intoprestodb:masterfrom
Closed
Add config/session property to control aggregate Spilling#16578pgupta2 wants to merge 1 commit intoprestodb:masterfrom
pgupta2 wants to merge 1 commit intoprestodb:masterfrom
Conversation
`spill_enabled` session property enable spills for all operators. Currently, We do not have any way to control aggergation spills explicitly. This PR adds a config to control aggregation spills.
fgwang7w
reviewed
Aug 13, 2021
Member
fgwang7w
left a comment
fgwang7w
left a comment
There was a problem hiding this comment.
Thanks for adding this level of spill control. You might want to consider adding a comment that this aggregation spill control supercedes distinctSpill(distinct-aggregation-spill-enabled) and OrderbySpill (order-by-aggregation-spill-enabled).
| @@ -1248,6 +1249,7 @@ public PhysicalOperation visitAggregation(AggregationNode node, LocalExecutionPl | |||
| node, | |||
| source, | |||
| spillEnabled, | |||
Member
There was a problem hiding this comment.
nit: better to make this varilable as an inline as well to align with other invocation of split parameters
Contributor
Author
There was a problem hiding this comment.
#16581 adds config/session properties for controlling aggregates/window/orderby spilling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spill_enabledsession property enable spills for all operators. Currently, We donot have any way to control aggregation spills explicitly. This PR adds a config to
control aggregation spills.
Test plan - Added a unit test