Add presto-docs/README.md with instructions to build Presto docs#16238
Merged
rongrong merged 1 commit intoprestodb:masterfrom Jun 18, 2021
Merged
Add presto-docs/README.md with instructions to build Presto docs#16238rongrong merged 1 commit intoprestodb:masterfrom
rongrong merged 1 commit intoprestodb:masterfrom
Conversation
rongrong
reviewed
Jun 17, 2021
presto-docs/README.md
Outdated
Contributor
There was a problem hiding this comment.
The previous commands about installing python / building the docs didn't mention bash specifically. I think people should generally understand these are shell commands so probably don't need to mention it?
rongrong
approved these changes
Jun 18, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - Tested these build instructions on my local system.
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.