Add support for Prometheus plugin#15194
Conversation
8809b41 to
652ff8d
Compare
presto-common/src/main/java/com/facebook/presto/common/type/TypeSignature.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusClock.java
Outdated
Show resolved
Hide resolved
...etheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusQueryResponseParse.java
Outdated
Show resolved
Hide resolved
...etheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusQueryResponseParse.java
Outdated
Show resolved
Hide resolved
...etheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusQueryResponseParse.java
Outdated
Show resolved
Hide resolved
...o-prometheus/src/main/java/com.facebook.presto.plugin.prometheus/PrometheusRecordCursor.java
Outdated
Show resolved
Hide resolved
...eus/src/test/java/com.facebook.presto.plugin.prometheus/TestPrometheusIntegrationTests1.java
Outdated
Show resolved
Hide resolved
|
Was there code in this PR copied from another project? If so please follow the attribution guidelines. |
|
hello team, just curious. Is the prometheus plug-in ready to roll out? I see these in the presto documentation https://prestosql.io/docs/current/connector/prometheus.html but I do not see a prometheus-plugin in the master branch |
|
@gtangthousandeyes PrestoSQL releases are maintained at https://github.com/prestosql/presto. |
0ba115c to
cd15425
Compare
|
@highker could you please help review this pr again? Thanks! |
b551aae to
450b897
Compare
|
@highker I fixed all the comments and ensure to use TIMESTAMP WITH TIME ZONE from Prometheus connector, please help review and approve the merge as many users are waiting for this feature to go in prestodb. many thanks! |
|
@zhenxiao could you please help give a final round of review on this PR? Thank you very much ! |
c9c6505 to
9d444ef
Compare
qqibrow
left a comment
There was a problem hiding this comment.
Overall looks good! Left a few comments.
presto-prometheus/src/main/java/com/facebook/presto/plugin/prometheus/PrometheusModule.java
Outdated
Show resolved
Hide resolved
...us/src/test/java/com/facebook/presto/plugin/prometheus/TestPrometheusMetricsIntegration.java
Outdated
Show resolved
Hide resolved
e4cffac to
a76a019
Compare
|
@zhenxiao all comments are addressed. please help review this PR, many thanks for your help! |
|
@highker @zhenxiao @qqibrow thank you all for reviewing the PRs. all of your comments were addressed and revisions are made accordingly. Test is good, could we have a final check on this PR? some community folks are asking for the status of this PR waiting for the feature to use. many thanks @beinan for your help too! |
beinan
left a comment
There was a problem hiding this comment.
The implementation looks good to me except a couple of coding style issue. But I might hesitate to put this connector into prestodb repo. As we discussed in the TSC meeting, @rongrong do you think if we can put this connector into a separate "plugins" repo? Or we can just merge it into the prestodb repo and then move it out? I think this connector would be a good starting point for the separate "plugins" repo.
presto-prometheus/src/main/java/com/facebook/presto/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
...-prometheus/src/main/java/com/facebook/presto/plugin/prometheus/PrometheusQueryResponse.java
Outdated
Show resolved
Hide resolved
...-prometheus/src/main/java/com/facebook/presto/plugin/prometheus/PrometheusQueryResponse.java
Outdated
Show resolved
Hide resolved
Cherry-pick of trinodb/trino#2321 Co-authored by: bentito <btofel@redhat.com>
This commit enables `TIMESTAMP WITH TIME ZONE`, and some code cleanup Cherry-pick of trinodb/trino#4756 Co-authored by: Dain Sundstrom <dain@iq80.com>
Thank you @beinan very much for approving the PR and giving a final review. Since this connector has finally been approved after a long wait and some community members are waiting for this feature to use, will it make sense to merge now? |
|
There's some infrastructure that needs to be set up before we can push forward on that approach, such as release jobs. Additionally, though it was discussed at the TSC meeting, it didn't reach consensus, and more followup discussion is needed. I would say for now let's keep it where it is, and we can find another good candidate in the future. |
|
Thank you @fgwang7w ,@tdcmeehan and all the reviewers of this giant PR! Let me merge this one to unblock @fgwang7w 's further work. I think we can discuss more about when and how we should separate plugins to another repo in the next TSC meeting. |
|
Thank you all @zhenxiao @highker @beinan @qqibrow for reviewing this very big PR, and many thanks for all community collaboration and teamwork to make it happen. |
resolves #15176
Test plan - tesed locally, add UT coverage for this connector