[WIP] Bypass http call if the node is local#13838
Closed
dharakk wants to merge 1 commit intoprestodb:masterfrom
Closed
[WIP] Bypass http call if the node is local#13838dharakk wants to merge 1 commit intoprestodb:masterfrom
dharakk wants to merge 1 commit intoprestodb:masterfrom
Conversation
If a global config is set and the node-uri matches the current node, then use the task manager directly for fetching exchange data and doing task calls. That is bypass the taskResource if these conditions are satisfied. In addition, the backoff changed such that the local mode never undergoes a backoff. It's a bit hacky but does the job. Can be enabled (default is disabled) by setting task.bypass-http-for-local=true
|
@dharakk, I just briefly skimmed through the PR and here are some high-level comments:
|
Author
Thanks @highker for the review. Having an abstraction is definitely the cleaner approach. I will rebase on top of #13894 and update |
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13937
If a global config is set and the node-uri matches the current
node, then use the task manager directly for fetching exchange data and
doing task calls. That is bypass the taskResource if these conditions
are satisfied.
In addition, the backoff changed such that the local mode
never undergoes a backoff. It's a bit hacky but does the job.
Can be enabled (default is disabled) by setting
task.bypass-http-for-local=true
In the low latency one-node setup (designed by @agrawaldevesh ), large sum of latency stemmed from http calls on the local host, this change helps shave of that latency piece