Add support for adding custom codecs with pom file #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
arhimondr
reviewed
May 21, 2025
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
6 tasks
shangm2
force-pushed
the
customCodecInPom
branch
2 times, most recently
from
93e2d4f to
79ce209
Compare
arhimondr
approved these changes
May 22, 2025
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
shangm2
commented
May 22, 2025
drift-idl-generator/src/main/java/com/facebook/drift/idl/generator/ThriftIdlGenerator.java
Outdated
Show resolved
Hide resolved
shangm2
added a commit
to prestodb/presto
that referenced
this pull request
May 22, 2025
## Description 1. Automatically generate idl file for 3 classes, taskStatus, taskInfo, and taskUpdateRequest via plugin 2. Requires prestodb/drift#63 ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan 1. Build successfully and the generated idl file looks good. <img width="1174" alt="Screenshot 2025-05-20 at 16 16 07" src="https://github.com/user-attachments/assets/3d20b193-9aed-4635-a4f4-f45ccdde8538" /> <img width="1134" alt="Screenshot 2025-05-20 at 17 19 08" src="https://github.com/user-attachments/assets/5fe74591-5f7c-458e-bb25-4616b612ccf0" /> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
|
@wanglinsong @shangm2 @arhimondr Just a heads up - we decided to migrate drift to airlift The drift code was migrated via - prestodb/airlift@7fc3927 While we are waiting for the updated airlift to land in Presto via the JDK Upgrade PR, can you make sure that if there are new changes that you're making here, they also are made against the airlift/drift version ? @ZacBlanco and I would be happy to review any PRs around this Update : Looks like @ZacBlanco and you'll have already connected. Ignore this comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we will be able to generate .thrift idl file by building the presto-thrift-spec module within presto like below
