Add support for adding custom codecs within pom file#114
Merged
ZacBlanco merged 1 commit intoprestodb:masterfrom May 23, 2025
Merged
Add support for adding custom codecs within pom file#114ZacBlanco merged 1 commit intoprestodb:masterfrom
ZacBlanco merged 1 commit intoprestodb:masterfrom
Conversation
ZacBlanco
reviewed
May 22, 2025
ZacBlanco
left a comment
ZacBlanco
left a comment
There was a problem hiding this comment.
Looks like we need to move some namespaces around
...ift-codec-utils/src/main/java/com/facebook/drift/codec/utils/DataSizeToBytesThriftCodec.java
Outdated
Show resolved
Hide resolved
...ift-codec-utils/src/main/java/com/facebook/drift/codec/utils/DataSizeToBytesThriftCodec.java
Outdated
Show resolved
Hide resolved
...ift-codec-utils/src/main/java/com/facebook/drift/codec/utils/DataSizeToBytesThriftCodec.java
Outdated
Show resolved
Hide resolved
...codec/src/main/java/com/facebook/drift/codec/internal/builtin/OptionalDoubleThriftCodec.java
Outdated
Show resolved
Hide resolved
...ift-codec/src/main/java/com/facebook/drift/codec/metadata/AbstractThriftMetadataBuilder.java
Outdated
Show resolved
Hide resolved
Author
|
@ZacBlanco hey, thanks a lot for pointing out all the namespace issue. Feel free to take another look. Thanks. |
ZacBlanco
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simply a copy of prestodb/drift#63 which has been merged so that we can have all latest code in this repo as well.