fix: load lock file with dependency override#4419
Conversation
Signed-off-by: HernandoR <lzhen.dev@outlook.com>
…iability verification Signed-off-by: HernandoR <lzhen.dev@outlook.com>
Signed-off-by: HernandoR <lzhen.dev@outlook.com>
|
@nichmor can you take some time reviewing this? |
|
Thanks @HernandoR I'll take a look tomorrow or Thursday :) |
…strain. Signed-off-by: HernandoR <lzhen.dev@outlook.com>
|
Yeah I verified the behavior with your test @HernandoR, and it seems to work! Are you on linux by chance and can you verify if the original issue is fixed? I can't get it into a shape thats runnable on my macOS machine. |
Co-authored-by: Tim de Jager <tdejager89@gmail.com>
Co-authored-by: Tim de Jager <tdejager89@gmail.com>
@tdejager I confirm it fixed the original issue on linux. |
|
Excellent work again @HernandoR, there are not a lot of external contributors fixing bugs from features they have introduced, this is really extremely appreciated! |
This pr trying to fix #4237;
I believe this issue is
verify_package_platform_satisfiabilitydid not consider the override options in environment. Hence concludes lock file can not satisfy the environment.I added a test case for
test_good_satisfiabilitywhich reflects this issue. Still thinking how to inject override options into environment requirements