Skip to content

fix: load lock file with dependency override#4419

Merged
tdejager merged 7 commits intoprefix-dev:mainfrom
HernandoR:lz/fix/load-overrided-lock-file
Aug 26, 2025
Merged

fix: load lock file with dependency override#4419
tdejager merged 7 commits intoprefix-dev:mainfrom
HernandoR:lz/fix/load-overrided-lock-file

Conversation

@HernandoR
Copy link
Contributor

This pr trying to fix #4237;

I believe this issue is verify_package_platform_satisfiability did not consider the override options in environment. Hence concludes lock file can not satisfy the environment.

I added a test case for test_good_satisfiability which reflects this issue. Still thinking how to inject override options into environment requirements

Signed-off-by: HernandoR <lzhen.dev@outlook.com>
…iability verification

Signed-off-by: HernandoR <lzhen.dev@outlook.com>
Signed-off-by: HernandoR <lzhen.dev@outlook.com>
@HernandoR
Copy link
Contributor Author

@nichmor can you take some time reviewing this?

@ruben-arts ruben-arts requested a review from tdejager August 25, 2025 10:59
@tdejager
Copy link
Contributor

Thanks @HernandoR I'll take a look tomorrow or Thursday :)

…strain.

Signed-off-by: HernandoR <lzhen.dev@outlook.com>
Copy link
Contributor

@tdejager tdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more small nits.

@tdejager
Copy link
Contributor

Yeah I verified the behavior with your test @HernandoR, and it seems to work!

Are you on linux by chance and can you verify if the original issue is fixed? I can't get it into a shape thats runnable on my macOS machine.

tdejager and others added 3 commits August 26, 2025 11:27
Co-authored-by: Tim de Jager <tdejager89@gmail.com>
Co-authored-by: Tim de Jager <tdejager89@gmail.com>
@HernandoR
Copy link
Contributor Author

Yeah I verified the behavior with your test @HernandoR, and it seems to work!

Are you on linux by chance and can you verify if the original issue is fixed? I can't get it into a shape thats runnable on my macOS machine.

@tdejager I confirm it fixed the original issue on linux.

@lucascolley lucascolley requested a review from tdejager August 26, 2025 12:38
@lucascolley lucascolley added the bug Something isn't working label Aug 26, 2025
@tdejager
Copy link
Contributor

Excellent work again @HernandoR, there are not a lot of external contributors fixing bugs from features they have introduced, this is really extremely appreciated!

@tdejager tdejager merged commit bd62770 into prefix-dev:main Aug 26, 2025
75 checks passed
@HernandoR HernandoR deleted the lz/fix/load-overrided-lock-file branch August 26, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After using dependency-overrides, updating locking will appear every time pixi shell is used

3 participants