refactor: Move task into new pixi_task crate#4401
Merged
Hofer-Julian merged 1 commit intoprefix-dev:mainfrom Aug 21, 2025
Merged
refactor: Move task into new pixi_task crate#4401Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
Conversation
haecker-felix
added
refactor
haecker-felix
force-pushed
the
pixi_task
branch
from
884f18e to
e8e4f3e
Compare
Hofer-Julian
approved these changes
Aug 20, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Changes look good to me.
Let's wait for @baszalmstra and @tdejager to have a look as well before merging
haecker-felix
force-pushed
the
pixi_task
branch
3 times, most recently
from
0ffc438 to
4794802
Compare
baszalmstra
approved these changes
Aug 21, 2025
Contributor
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
One small comment, otherwise looks good
haecker-felix
force-pushed
the
pixi_task
branch
from
4794802 to
110b0fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
taskmodule into a newpixi_taskcrate.Had to move
EnvironmentHashintopixi_core/environment, asactivationinpixi_corealso depends on it (but can't depend onpixi_task, aspixi_taskalready depends onpixi_core).