fix: revert env var changes#4346
Merged
ruben-arts merged 5 commits intoprefix-dev:mainfrom Aug 14, 2025
Merged
Conversation
…-dev#4282)" This reverts commit d06323c.
…riables (prefix-dev#4275)" This reverts commit 58c3b9b.
…-dev#3940)" This reverts commit 23fa3f5.
Contributor
|
For me locally this solved all the issues I had, while reintroducing the original issue. But I think this is the best we can do in the short term. |
Collaborator
|
the plan sounds good to me. Let's make sure we keep track of the docs that were added, they can be reintroduced with the new implementation. |
Contributor
Author
Yep, agreed |
ruben-arts
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, we found too many issues with our current env var handling, and @ruben-arts and I couldn't find a clear way to go forward here.
This PR reverts all changes that we added recently.
@magentaqin