fix: feature activation environment variable priority#4282
Merged
Hofer-Julian merged 3 commits intoprefix-dev:mainfrom Aug 7, 2025
Merged
Conversation
…es in default activation.env
Hofer-Julian
reviewed
Aug 6, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Good catch, one small comment, then we can merge it
src/workspace/environment.rs
Outdated
|
|
||
| [environments] | ||
| foo = ["foo"] | ||
| cuda = ["cuda"] |
Contributor
There was a problem hiding this comment.
Suggested change
| cuda = ["cuda"] | |
| cuda = ["foo", "cuda"] |
This way we ensure that "cuda" indeed has the highest priority
Contributor
Author
There was a problem hiding this comment.
I updated the tests. but as self.features() returns ["cuda1","cuda2", "default"], rfold result is ["default", "cuda2","cuda1"]. so "cuda1" takes the priority.
Hofer-Julian
changed the title
Hofer-Julian
approved these changes
Aug 7, 2025
Hofer-Julian
added a commit
to Hofer-Julian/pixi
that referenced
this pull request
Aug 14, 2025
…-dev#4282)" This reverts commit d06323c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix: #4116
What I changed
As self.features() would put "default" envs in the last item, but the "default" env priority should be the lowest.Here, we use rfold (reverse fold) to ensure later features override earlier features for environment variables. Processing features in reverse order means that features appearing later in the list will have higher precedence.
Example: If features: [override_feature, user_feature, default]
rfold processes as: [default, user_feature, override_feature]
Result: override_feature env vars take precedence over all others.