Skip to content

fix: update named arg schema#4324

Merged
lucascolley merged 3 commits intoprefix-dev:mainfrom
bollwyvl:gh-4148-named-arg-schema
Aug 13, 2025
Merged

fix: update named arg schema#4324
lucascolley merged 3 commits intoprefix-dev:mainfrom
bollwyvl:gh-4148-named-arg-schema

Conversation

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Aug 12, 2025

references

changes

  • update args schema to reflect current reading
  • add TaskArgName with regex for arg names
  • update task_arguments_dependent.toml example to exercise/document more features

questions

  • the task arg name regular expression needs a look
    • i don't think minijinja vars can start with numbers
    • i don't know about full unicode, could get hairy

@lucascolley lucascolley self-requested a review August 12, 2025 16:00
@lucascolley lucascolley added the area:tasks Related to pixi tasks label Aug 12, 2025
@bollwyvl bollwyvl changed the title update named arg schema fix: update named arg schema Aug 12, 2025
@bollwyvl bollwyvl marked this pull request as ready for review August 12, 2025 16:16
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Aug 12, 2025

Could add some more invalid fixtures, I suppose, but otherwise this seems ready to review.

Copy link
Collaborator

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bollwyvl, LGTM!

the task arg name regular expression needs a look
i don't think minijinja vars can start with numbers
i don't know about full unicode, could get hairy

I'm not too worried about getting this 100% perfect, I think we should just merge this and iterate :)

@lucascolley lucascolley added the bug Something isn't working label Aug 13, 2025
@lucascolley lucascolley enabled auto-merge (squash) August 13, 2025 09:56
@lucascolley lucascolley merged commit ad595c5 into prefix-dev:main Aug 13, 2025
112 of 114 checks passed
@bollwyvl bollwyvl deleted the gh-4148-named-arg-schema branch August 13, 2025 12:14
@bollwyvl bollwyvl mentioned this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tasks Related to pixi tasks bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants