fix: update named arg schema#4324
Merged
lucascolley merged 3 commits intoprefix-dev:mainfrom Aug 13, 2025
Merged
Conversation
Contributor
Author
|
Could add some more |
bollwyvl
commented
Aug 12, 2025
lucascolley
approved these changes
Aug 13, 2025
Collaborator
lucascolley
left a comment
There was a problem hiding this comment.
thanks @bollwyvl, LGTM!
the task arg name regular expression needs a look
i don't think minijinja vars can start with numbers
i don't know about full unicode, could get hairy
I'm not too worried about getting this 100% perfect, I think we should just merge this and iterate :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references
depends-on#4148changes
argsschema to reflect current readingTaskArgNamewith regex for arg namestask_arguments_dependent.tomlexample to exercise/document more featuresquestions