feat(tasks): named args in depends-on#4148
Merged
Hofer-Julian merged 14 commits intoprefix-dev:mainfrom Jul 31, 2025
Merged
Conversation
lucascolley
force-pushed
the
named-args-depends-on
branch
2 times, most recently
from
d67dae5 to
f5cdb3a
Compare
lucascolley
force-pushed
the
named-args-depends-on
branch
from
f5cdb3a to
6624b9e
Compare
lucascolley
changed the title
lucascolley
changed the title
depends-on
lucascolley
force-pushed
the
named-args-depends-on
branch
from
6624b9e to
25a4714
Compare
lucascolley
force-pushed
the
named-args-depends-on
branch
from
25a4714 to
9c7a42d
Compare
lucascolley
commented
Jul 17, 2025
Collaborator
Author
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
some self-review
lucascolley
commented
Jul 17, 2025
lucascolley
changed the title
depends-ondepends-on
lucascolley
commented
Jul 17, 2025
lucascolley
changed the title
depends-ondepends-on
Hofer-Julian
requested changes
Jul 22, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Looks good!
Could you please adapt the schema in schema/model.py so that all strings that can be templated use a different type with a suitable docstring?
Hofer-Julian
requested changes
Jul 31, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
A few small comments. After they are fixed this is good for me to go :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looking to close gh-3536 (eventually)
potential follow-ups tracked in gh-4208
TODO here:
schema/model.py