Skip to content

fix: shell-hook, avoid run unexpected commands #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfv merged 2 commits into from
Apr 4, 2025
Merged

fix: shell-hook, avoid run unexpected commands #3493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4ca5d
fix shell-hook
gzm55 Apr 2, 2025
1de4eb7
restore rehash on zsh
gzm55 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/shell_snippets/pixi-bash.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
# shellcheck shell=bash
pixi() {
local first_arg="$1"
local cmd="$PIXI_EXE $*"
local first_arg="${1-}"

eval "$cmd"
"${PIXI_EXE-}" "$@" || return $?

case "$first_arg" in
case "${first_arg-}" in
add|a|remove|rm|install|i)
eval "$($PIXI_EXE shell-hook --change-ps1 false)"
eval "$("$PIXI_EXE" shell-hook --change-ps1 false)"
hash -r
;;
esac
esac || :

return 0
}
13 changes: 7 additions & 6 deletions src/shell_snippets/pixi-zsh.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
# shellcheck disable=all
pixi() {
local first_arg="$1"
local cmd="$PIXI_EXE $*"
local first_arg="${1-}"

eval "$cmd"
"${PIXI_EXE-}" "$@" || return $?

case "$first_arg" in
case "${first_arg-}" in
add|a|remove|rm|install|i)
eval "$($PIXI_EXE shell-hook --change-ps1 false)"
eval "$("$PIXI_EXE" shell-hook --change-ps1 false)"
rehash # Clear the command hash table in zsh
;;
esac
esac || :

return 0
}
Loading