Skip to content

fix: shell-hook, avoid run unexpected commands#3493

Merged
wolfv merged 2 commits intoprefix-dev:mainfrom
gzm55:work/fix-3490
Apr 4, 2025
Merged

fix: shell-hook, avoid run unexpected commands#3493
wolfv merged 2 commits intoprefix-dev:mainfrom
gzm55:work/fix-3490

Conversation

@gzm55
Copy link
Copy Markdown
Contributor

@gzm55 gzm55 commented Apr 2, 2025

close #3490
close #3308

  1. use $PIXI_EXE "$@" to run the main command.
  2. respect the exit code of the main commmand

@gzm55 gzm55 changed the title fix shell-hook, avoid run unexpected commands fix: shell-hook, avoid run unexpected commands Apr 2, 2025
@wolfv
Copy link
Copy Markdown
Member

wolfv commented Apr 3, 2025

Ah this also fixes #3308 and could supersede my PR in #3504

@gzm55
Copy link
Copy Markdown
Contributor Author

gzm55 commented Apr 4, 2025

Ah this also fixes #3308 and could supersede my PR in #3504

@wolfv thanks

@wolfv wolfv requested a review from Copilot April 4, 2025 05:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/shell_snippets/pixi-bash.sh: Language not supported
  • src/shell_snippets/pixi-zsh.sh: Language not supported

@wolfv
Copy link
Copy Markdown
Member

wolfv commented Apr 4, 2025

Tested locally and this works - merging.

@wolfv wolfv merged commit 9e3d0a0 into prefix-dev:main Apr 4, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pixi() in shell-hook may execute unexpected commands Exit code always 0 when running task inside activated environment

3 participants