Skip to content

perf: only call pixi global completion functions when necessary #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hofer-Julian merged 4 commits into from
Apr 2, 2025
Merged

perf: only call pixi global completion functions when necessary #3477

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e026886
perf: skip `pixi global` completion functions on windows
Hofer-Julian Apr 1, 2025
2352049
Only compile on Windows
Hofer-Julian Apr 2, 2025
b44a07c
Only compile and run code if necessary
Hofer-Julian Apr 2, 2025
7c1989a
Add comments
Hofer-Julian Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/global/completions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ impl CompletionsDir {
}

/// Prune old completions
#[cfg(unix)]
pub fn prune_old_completions(&self) -> miette::Result<()> {
for directory in [self.bash_path(), self.zsh_path(), self.fish_path()] {
if !directory.is_dir() {
Expand All @@ -55,6 +56,12 @@ impl CompletionsDir {
Ok(())
}

/// Prune old completions
#[cfg(not(unix))]
pub fn prune_old_completions(&self) -> miette::Result<()> {
Ok(())
}

pub fn bash_path(&self) -> PathBuf {
self.path().join("bash")
}
Expand Down Expand Up @@ -198,6 +205,7 @@ pub fn contained_completions(
/// based on the provided `exposed_mappings` and `executable_names`. It compares the
/// current state of the completion scripts in the `completions_dir` with the expected
/// state derived from the `exposed_mappings`.
#[cfg(unix)]
pub(crate) async fn completions_sync_status(
exposed_mappings: IndexSet<Mapping>,
executable_names: Vec<String>,
Expand Down Expand Up @@ -241,3 +249,13 @@ pub(crate) async fn completions_sync_status(

Ok((completions_to_remove, completions_to_add))
}

#[cfg(not(unix))]
pub(crate) async fn completions_sync_status(

@nichmor nichmor Apr 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add a small comment ( from the PR overview ) to mention that we never install completions on windows that's why we don't need to check it here?

@Hofer-Julian Hofer-Julian Apr 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

exposed_mappings: IndexSet<Mapping>,
executable_names: Vec<String>,
prefix_root: &Path,
completions_dir: &CompletionsDir,
) -> miette::Result<(Vec<Completion>, Vec<Completion>)> {
Ok((Vec::new(), Vec::new()))
}
10 changes: 10 additions & 0 deletions src/global/project/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,7 @@ impl Project {
Ok(state_changes)
}

#[cfg(unix)]
pub async fn sync_completions(
&self,
env_name: &EnvironmentName,
Expand Down Expand Up @@ -1294,6 +1295,15 @@ impl Project {
Ok(state_changes)
}

#[cfg(not(unix))]
pub async fn sync_completions(
&self,
env_name: &EnvironmentName,
) -> miette::Result<StateChanges> {
let mut state_changes = StateChanges::default();
Ok(state_changes)
}

/// Returns a semaphore than can be used to limit the number of concurrent
/// according to the user configuration.
fn concurrent_downloads_semaphore(&self) -> Arc<Semaphore> {
Expand Down