perf: only call pixi global completion functions when necessary#3477
Merged
Hofer-Julian merged 4 commits intoprefix-dev:mainfrom Apr 2, 2025
Merged
Conversation
On windows we never install completions, so let's also avoid the completion checks then
nichmor
approved these changes
Apr 2, 2025
src/global/completions.rs
Outdated
| } | ||
|
|
||
| #[cfg(not(unix))] | ||
| pub(crate) async fn completions_sync_status( |
Contributor
There was a problem hiding this comment.
maybe we can add a small comment ( from the PR overview ) to mention that we never install completions on windows that's why we don't need to check it here?
Hofer-Julian
changed the title
pixi global completion functions on windowspixi global completion functions when necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3476
On Windows we never install completions, so let's also avoid the completion checks then
Also skip completions check for
environment_in_sync.This check is pretty expensive and unless users manually remove things in that directory, that check also isn't necessary.