feat: argument variables in tasks by prsabahrami · Pull Request #3433 · prefix-dev/pixi

prsabahrami · 2025-03-25T17:47:17Z

Adds support for arguments passed into the task commands

Hofer-Julian

Had a quick glance at the tests and left a few comments. Will try the code changes tomorrow. Would be good to solve the merge conflicts until then. Not sure what's up with the trampoline, but, I think you can just throw away your trampoline changes and take the ones from main

tests/integration_python/test_run_cli.py

Hofer-Julian

Had another quick look and added a few nitpicks

crates/pixi_manifest/src/task.rs

tests/integration_python/test_run_cli.py

Hofer-Julian · 2025-03-28T08:21:07Z

@prsabahrami I force pushed to your branch to get rid of the unnecessary trampoline changes

src/task/task_graph.rs

Hofer-Julian · 2025-03-28T08:49:55Z

Things to do before we can merge this:

Update schema/model.py and run pixi run generate-schema
Extend docs/workspace/advanced_tasks.md

.pre-commit-config.yaml

crates/pixi_manifest/src/toml/task.rs

chore: raise an error if a there is an argument with no default after one with a default chore: add support for running tasks with arguments passed via cli chore: add support for running tasks with arguments passed via depends fix: the serialization of dependencies as tables in tasks Update crates/pixi_manifest/src/task.rs Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> chore: remove unused struct `DisplayDependency` chore: change to a struct fix: use library and a dictionary to create the task argument tests chore: remove extra method from Dependency chore: add pre-commit-minimal back (#3449) refactor: rename variables for clarity in task argument tests fix: add the trampoline binary back update trampoline binaries [CI]: Update trampoline binaries for all targets Remove unneeded implementation Update src/task/task_graph.rs Co-authored-by: Tim de Jager <tim@prefix.dev>

ruben-arts · 2025-03-28T15:29:56Z

Hey @prsabahrami, already great work!

I'm finding some UX things that I would like to improve:

In this example could you make the blue task rendered with the argument.

Could you make the error more readable, using colors would be awesome, but the way it's formatted currently makes it hard to read.

Could you extend this error with what it expected vs what it got, possibly with a help to quote the input to make it fit into one.

Please make sure that it's documented well that with an argument and without acts differently with the trailing commands.

ruben-arts · 2025-03-28T16:17:20Z

Could you add an example that uses this feature to the examples/

prsabahrami · 2025-03-30T04:19:04Z

@Hofer-Julian ready for your review!

prsabahrami · 2025-04-01T19:37:40Z

This is how the errors are being shown right now. Let me know if you have any comments!

Hofer-Julian

A few comments to improve the docs

docs/workspace/advanced_tasks.md

Hofer-Julian · 2025-04-02T09:13:05Z

One other thing, I remember: you added the logic to deal with this case, right?

A depends on B and D
B depends on C with args 1
D depends on D with args 2

Do we have tests for that?
If not, let's add a couple of scenarios here!

Hofer-Julian

A few code comments

src/task/executable_task.rs

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

…tomls

… files

Hofer-Julian

Awesome work @prsabahrami 🚀

I tweaked docs and error messages a bit. Let's bring it in!

bollwyvl · 2025-04-07T14:33:56Z

Are {{ arg }} values available in inputs and outputs?

A quick look through the code suggests no... will make a separate issue.

Hofer-Julian · 2025-04-07T14:50:57Z

A quick look through the code suggests no... will make a separate issue.

Yeah, please do so, we are open to adding argument expansion to other fields where it makes sense

bollwyvl · 2025-04-07T15:12:59Z

#3533

prsabahrami changed the title ~~feat: argument variables in tasks~~ wip: argument variables in tasks Mar 25, 2025

Hofer-Julian reviewed Mar 26, 2025

View reviewed changes

tests/integration_python/test_run_cli.py Show resolved Hide resolved

tests/integration_python/test_run_cli.py Outdated Show resolved Hide resolved

tests/integration_python/test_run_cli.py Outdated Show resolved Hide resolved

Hofer-Julian reviewed Mar 27, 2025

View reviewed changes

crates/pixi_manifest/src/task.rs Outdated Show resolved Hide resolved

crates/pixi_manifest/src/task.rs Outdated Show resolved Hide resolved

crates/pixi_manifest/src/task.rs Outdated Show resolved Hide resolved

crates/pixi_manifest/src/task.rs Outdated Show resolved Hide resolved

prsabahrami marked this pull request as ready for review March 27, 2025 16:26

prsabahrami requested a review from Hofer-Julian March 27, 2025 16:26

prsabahrami changed the title ~~wip: argument variables in tasks~~ feat: argument variables in tasks Mar 27, 2025

Hofer-Julian reviewed Mar 27, 2025

View reviewed changes

crates/pixi_manifest/src/task.rs Outdated Show resolved Hide resolved

Hofer-Julian reviewed Mar 27, 2025

View reviewed changes

tests/integration_python/test_run_cli.py Outdated Show resolved Hide resolved

prsabahrami force-pushed the feat_taskargs branch from 9117731 to 4b4cc0f Compare March 27, 2025 19:59

prsabahrami requested a review from Hofer-Julian March 27, 2025 20:07

Hofer-Julian force-pushed the feat_taskargs branch from 0fcdff7 to 07767f2 Compare March 28, 2025 08:12

tdejager reviewed Mar 28, 2025

View reviewed changes

src/task/task_graph.rs Outdated Show resolved Hide resolved

nichmor reviewed Mar 28, 2025

View reviewed changes

.pre-commit-config.yaml Show resolved Hide resolved

Hofer-Julian reviewed Mar 28, 2025

View reviewed changes

crates/pixi_manifest/src/toml/task.rs Outdated Show resolved Hide resolved

crates/pixi_manifest/src/toml/task.rs Outdated Show resolved Hide resolved

Hofer-Julian force-pushed the feat_taskargs branch from 46aac97 to b4ad922 Compare March 28, 2025 09:54

prsabahrami added 2 commits March 30, 2025 00:18

add example, fix ux, and replace arg names

9f3c8b7

Merge branch 'main' into feat_taskargs

8ffa6a7

prsabahrami requested review from Hofer-Julian, nichmor and tdejager March 30, 2025 04:19

prsabahrami added 4 commits March 30, 2025 00:20

add example, fix ux, and replace arg names

93f13b4

update schema

385bc7d

fix pre-commit and schema

be49655

update calculator example

f3de226

refactor: update the error prints for replacing arguments

0826b6c

Hofer-Julian reviewed Apr 2, 2025

View reviewed changes

docs/workspace/advanced_tasks.md Outdated Show resolved Hide resolved

docs/workspace/advanced_tasks.md Outdated Show resolved Hide resolved

docs/workspace/advanced_tasks.md Outdated Show resolved Hide resolved

docs/workspace/advanced_tasks.md Outdated Show resolved Hide resolved

Improve highlighting slightly

a27433e

Hofer-Julian reviewed Apr 2, 2025

View reviewed changes

src/task/executable_task.rs Outdated Show resolved Hide resolved

src/task/executable_task.rs Outdated Show resolved Hide resolved

prsabahrami and others added 5 commits April 2, 2025 09:46

Update src/task/executable_task.rs

ca07248

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

Update src/task/executable_task.rs

01366f6

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

update docs and remove real-world example and move the tomls to pixi_…

f5c75c1

…tomls

add: a test for multiple inputs to a simple task case

7039a43

Merge branch 'main' into feat_taskargs

0a74f55

prsabahrami requested a review from Hofer-Julian April 2, 2025 15:18

prsabahrami and others added 8 commits April 2, 2025 11:45

Merge branch 'main' into feat_taskargs

d94a292

update docs

3e5a6e1

refactor: change section header from [project] to [workspace] in TOML…

3827b4e

… files

Merge branch 'main' into feat_taskargs

bf059d2

chore: remove extra print

131dc60

Make the tomls prettier

de8491c

Clarify error message

a14e832

Adapt error messages and tests

a7eec79

Hofer-Julian approved these changes Apr 3, 2025

View reviewed changes

Hofer-Julian enabled auto-merge (squash) April 3, 2025 07:57

Hofer-Julian merged commit 76369f2 into main Apr 3, 2025
33 checks passed

Hofer-Julian deleted the feat_taskargs branch April 3, 2025 08:02

lucascolley mentioned this pull request Apr 5, 2025

CI: test macOS scipy/xsf#19

Merged

bollwyvl mentioned this pull request Apr 7, 2025

Variable expansion in inputs/outputs #3533

Closed

BrewTestBot mentioned this pull request Apr 7, 2025

pixi 0.45.0 Homebrew/homebrew-core#218676

Merged

Conversation

prsabahrami commented Mar 25, 2025

Uh oh!

Hofer-Julian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hofer-Julian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hofer-Julian commented Mar 28, 2025

Uh oh!

Uh oh!

Hofer-Julian commented Mar 28, 2025 • edited by prsabahrami Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ruben-arts commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ruben-arts commented Mar 28, 2025

Uh oh!

prsabahrami commented Mar 30, 2025

Uh oh!

prsabahrami commented Apr 1, 2025

Uh oh!

Hofer-Julian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hofer-Julian commented Apr 2, 2025

Uh oh!

Hofer-Julian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Hofer-Julian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bollwyvl commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hofer-Julian commented Apr 7, 2025

Uh oh!

bollwyvl commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hofer-Julian commented Mar 28, 2025 •

edited by prsabahrami

Loading

ruben-arts commented Mar 28, 2025 •

edited

Loading

bollwyvl commented Apr 7, 2025 •

edited

Loading