chore: add pre-commit-minimal back#3449
Merged
Hofer-Julian merged 2 commits intoprefix-dev:mainfrom Mar 27, 2025
Merged
Conversation
I tried "cargo-clippy" in my pre-commit now for a while, but the overhead is just to much. I want my minimal version back again :)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces a minimal pre-commit installation option while updating hook configuration to reflect a desired workflow change. Key changes include:
- Modifying the pre-commit install command in pixi.toml to support both pre-commit and pre-push hooks.
- Adding a new pre-commit-install-minimal command for a leaner setup.
- Updating the hook stage in .pre-commit-config.yaml from pre-commit to pre-push.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pixi.toml | Updated pre-commit commands and added a minimal install option to reduce overhead. |
| .pre-commit-config.yaml | Changed the hook stage to pre-push for the cargo-clippy command execution. |
Comments suppressed due to low confidence (1)
.pre-commit-config.yaml:102
- [nitpick] Ensure that updating the hook stage to pre-push aligns with the intended workflow, as this change may alter when the checks are executed. If intentional as part of reverting to a minimal setup, consider adding a comment to document the rationale.
stages: [pre-push, manual]
Contributor
Author
|
Merging it now, since it also fixes CI on main |
Hofer-Julian
added a commit
that referenced
this pull request
Mar 28, 2025
chore: raise an error if a there is an argument with no default after one with a default chore: add support for running tasks with arguments passed via cli chore: add support for running tasks with arguments passed via depends fix: the serialization of dependencies as tables in tasks Update crates/pixi_manifest/src/task.rs Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> chore: remove unused struct `DisplayDependency` chore: change to a struct fix: use library and a dictionary to create the task argument tests chore: remove extra method from Dependency chore: add pre-commit-minimal back (#3449) refactor: rename variables for clarity in task argument tests fix: add the trampoline binary back update trampoline binaries [CI]: Update trampoline binaries for all targets
Hofer-Julian
added a commit
that referenced
this pull request
Mar 28, 2025
chore: raise an error if a there is an argument with no default after one with a default chore: add support for running tasks with arguments passed via cli chore: add support for running tasks with arguments passed via depends fix: the serialization of dependencies as tables in tasks Update crates/pixi_manifest/src/task.rs Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> chore: remove unused struct `DisplayDependency` chore: change to a struct fix: use library and a dictionary to create the task argument tests chore: remove extra method from Dependency chore: add pre-commit-minimal back (#3449) refactor: rename variables for clarity in task argument tests fix: add the trampoline binary back update trampoline binaries [CI]: Update trampoline binaries for all targets Remove unneeded implementation Update src/task/task_graph.rs Co-authored-by: Tim de Jager <tim@prefix.dev>
prsabahrami
pushed a commit
that referenced
this pull request
Apr 3, 2025
chore: raise an error if a there is an argument with no default after one with a default chore: add support for running tasks with arguments passed via cli chore: add support for running tasks with arguments passed via depends fix: the serialization of dependencies as tables in tasks Update crates/pixi_manifest/src/task.rs Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> chore: remove unused struct `DisplayDependency` chore: change to a struct fix: use library and a dictionary to create the task argument tests chore: remove extra method from Dependency chore: add pre-commit-minimal back (#3449) refactor: rename variables for clarity in task argument tests fix: add the trampoline binary back update trampoline binaries [CI]: Update trampoline binaries for all targets Remove unneeded implementation Update src/task/task_graph.rs Co-authored-by: Tim de Jager <tim@prefix.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried "cargo-clippy" in my pre-commit now for a while, but the overhead is just to much.
I want my minimal version back again :)