-
Notifications
You must be signed in to change notification settings - Fork 536
fix: some unexpected behavior of pixi global update
#3373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hofer-Julian
merged 29 commits into
prefix-dev:main
from
Glatzel:fix-pixi-global-update
Mar 19, 2025
+145
−12
Merged
Changes from 6 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d04661b
fix unexpected exposed removal
Glatzel 1749820
add comment
Glatzel 03faefa
clippy
Glatzel a64867f
fix unexpected error message if env is not existed
Glatzel 6edc4ce
Merge branch 'main' into fix-pixi-global-update
Glatzel 282b188
fmt
Glatzel 8dc6c98
Merge branch 'main' into fix-pixi-global-update
Glatzel d6a6074
initial test
Glatzel 8ac466c
fmt
Glatzel 9631eeb
Merge branch 'main' into fix-pixi-global-update
Hofer-Julian 0593125
fix test binary path
Glatzel 1726a95
revert test binary path to bin
Glatzel fd2b6b3
add real-world dotnet test
Glatzel bfdbc68
fix manifest
Glatzel 777b582
fix exposed_mapping_binaries when env is not existed but exposed exists.
Glatzel 4d0902d
revert exposed_mapping_binaries
Glatzel eb930cc
fix env path
Glatzel 14c245a
fmt
Glatzel 8a5669e
skip test on win as it need admin permission
Glatzel b1f568c
initial update remove deprecated env
Glatzel be1075d
add error handling and fmt
Glatzel bafaffb
add test_update_remove_old_env
Glatzel 81c9174
fix test
Glatzel 38f34dd
fix comment
Glatzel 82a42b0
Check if environment is in sync, instead of installing on failure
Hofer-Julian 4206a04
Simplify environment pruning
Hofer-Julian 39a2bcd
Improve logic and test code and also run on Windows
Hofer-Julian c40ac52
Remove unneeded test
Hofer-Julian 7eb32e9
Remove exitcode success
Hofer-Julian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it might resolve the error I'm seeing in:
pixi global updatefails if the environments are not in sync #3377Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks your issue is the subset of mine in #3366. I think this pr will fix it. I think pixi actually install the global tool, but it also throws a unneeded error message.