fix: some unexpected behavior of pixi global update#3373
fix: some unexpected behavior of pixi global update#3373Hofer-Julian merged 29 commits intoprefix-dev:mainfrom Glatzel:fix-pixi-global-update
pixi global update#3373Conversation
pixi global update unintended behaviorpixi global update
|
Hi,@Hofer-Julian . Can you have a look? My local test now looks well to solve these two problem. But can not confirm which could be better, trying to install env like the changes in my commit, or just disable the error message when If everything is ok, I will add a test. |
src/cli/global/update.rs
Outdated
| Err(_) => { | ||
| let _ = project.install_environment(env_name).await?; | ||
| project.executables_of_direct_dependencies(env_name).await? | ||
| } |
There was a problem hiding this comment.
This looks like it might resolve the error I'm seeing in:
There was a problem hiding this comment.
looks your issue is the subset of mine in #3366. I think this pr will fix it. I think pixi actually install the global tool, but it also throws a unneeded error message.
|
Thanks for your contribution @Glatzel, I plan to have a closer look within this week! One thing that would be good to add before we merge it, is to add a test in |
|
@Hofer-Julian Test is done. @dhirschfeld you can now test with binary from latest ci. Let me know if it works on your scenario. |
pixi global updatepixi global update
Hofer-Julian
left a comment
There was a problem hiding this comment.
Thanks for your contribution @Glatzel, much appreciated ✨
I've pushed a few improvements to your branch.
|
Thanks @Hofer-Julian and prefix team. Fluent experience of my first open source contribution with just 3 months rust knowledge. I can now manage my local cli tools with pixi and rattler-build. 🍻 |
Very impressive, hope it won't be your last one then 😄 |
fix #3366, fix #3377, fix #3381
test fail on main
https://github.com/Glatzel/pixi/actions/runs/13941514576/job/39019254621
update