Skip to content

fix: some unexpected behavior of pixi global update#3373

Merged
Hofer-Julian merged 29 commits intoprefix-dev:mainfrom
Glatzel:fix-pixi-global-update
Mar 19, 2025
Merged

fix: some unexpected behavior of pixi global update#3373
Hofer-Julian merged 29 commits intoprefix-dev:mainfrom
Glatzel:fix-pixi-global-update

Conversation

@Glatzel
Copy link
Copy Markdown
Contributor

@Glatzel Glatzel commented Mar 18, 2025

fix #3366, fix #3377, fix #3381

  • fix
    • disable error message if env is not existed.
    • unexpected exposed removal.
    • remove deprecated env
  • test
    • test_update_env_not_installed
    • test_update_custom_exposed_twice
    • test_update_custom_exposed_twice_slow(use dotnet example)
    • test_update_remove_deprecated_env

test fail on main

https://github.com/Glatzel/pixi/actions/runs/13941514576/job/39019254621

update

  • March 19, 2025, utc 03:37, add test_update_custom_exposed_twice_slow with dotnet example and some cases for test_update_custom_exposed_twice
  • March 19, 2025, utc 08:04, add test_update_remove_deprecated_env

@Glatzel Glatzel changed the title fix: pixi global update unintended behavior fix: disable unintended error message and exposed removal of pixi global update Mar 18, 2025
@Glatzel Glatzel marked this pull request as ready for review March 18, 2025 11:54
@Glatzel
Copy link
Copy Markdown
Contributor Author

Glatzel commented Mar 18, 2025

Hi,@Hofer-Julian . Can you have a look?

My local test now looks well to solve these two problem.

But can not confirm which could be better, trying to install env like the changes in my commit, or just disable the error message when executables_of_direct_dependencies raises PrefixError.DesignatedPackageNotFound. If the latter one is better, can you give me any hint about how to temporarily disable this error message.

If everything is ok, I will add a test.

Comment on lines +34 to +37
Err(_) => {
let _ = project.install_environment(env_name).await?;
project.executables_of_direct_dependencies(env_name).await?
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might resolve the error I'm seeing in:

Copy link
Copy Markdown
Contributor Author

@Glatzel Glatzel Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks your issue is the subset of mine in #3366. I think this pr will fix it. I think pixi actually install the global tool, but it also throws a unneeded error message.

@Hofer-Julian
Copy link
Copy Markdown
Contributor

Thanks for your contribution @Glatzel, I plan to have a closer look within this week!

One thing that would be good to add before we merge it, is to add a test in tests/integration_python/pixi_global that fails on main and succeeds with your PR.

@Glatzel
Copy link
Copy Markdown
Contributor Author

Glatzel commented Mar 18, 2025

@Hofer-Julian Test is done.


@dhirschfeld you can now test with binary from latest ci. Let me know if it works on your scenario.

@Glatzel Glatzel changed the title fix: disable unintended error message and exposed removal of pixi global update fix: some unexpected behavior of pixi global update Mar 19, 2025
Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Glatzel, much appreciated ✨

I've pushed a few improvements to your branch.

@Hofer-Julian Hofer-Julian merged commit cf0d40e into prefix-dev:main Mar 19, 2025
29 checks passed
@Glatzel
Copy link
Copy Markdown
Contributor Author

Glatzel commented Mar 19, 2025

Thanks @Hofer-Julian and prefix team.

Fluent experience of my first open source contribution with just 3 months rust knowledge.

I can now manage my local cli tools with pixi and rattler-build. 🍻

@Hofer-Julian
Copy link
Copy Markdown
Contributor

Thanks @Hofer-Julian and prefix team.

Fluent experience of my first open source contribution with just 3 months rust knowledge.

Very impressive, hope it won't be your last one then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants