Skip to content

Conversation

@BenjaminRodenberg
Copy link
Member

This release comes with some minor modifications to simplify the installation process and an important bugfix when subcycling is used (see #172).

BenjaminRodenberg and others added 11 commits August 5, 2024 11:37
* Add dockerfile used for `benjaminrodenberg/fenics`
* Use `pip install --break-system-packages ...`.
* Fixes tests
* Add tests to check if SolverState stores and returns the checkpointed state correctly

---------

Co-authored-by: Benjamin Rodenberg <[email protected]>
…ing installation (#181)

* Require mpi4py < 4

---------

Co-authored-by: Benjamin Rodenberg <[email protected]>
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code related changes make sense; the CI stuff not so much.

@NiklasVin
Copy link
Collaborator

There are also two open PRs I created (#178 and #183) that close two issues (from 2020 and 2023). Don't we want to add them to the new release as well? If releasing this version is urgent, it makes sense to not include them.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My earlier comments have been addressed to a reasonable degree. Release is good to go 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants