Remove checks for FEniCS and python3#182
Merged
BenjaminRodenberg merged 2 commits intodevelopfrom Sep 5, 2024
Merged
Conversation
fsimonis
reviewed
Sep 5, 2024
fsimonis
approved these changes
Sep 5, 2024
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
BenjaminRodenberg
added a commit
to NiklasVin/fenics-adapter
that referenced
this pull request
Nov 7, 2024
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the checks for the following reasons:
setup.pyto avoid crash due to version 4.0.0 ofmpi4pyduring installation #181pip install .the warnings are not shown. The warnings only appear for the deprecatedpython3 setup.py installWe can check for the python version (and potentially also FEniCS) when moving to
pyproject.tomlin a better way (see #179).