Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wmr) - support tsconfig-paths out of the box #875

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

JoviDeCroock
Copy link
Member

resolves #740

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2021

🦋 Changeset detected

Latest commit: 9773cca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2021

Size Change: +10.2 kB (+1%)

Total Size: 803 kB

Filename Size Change
examples/demo/dist/about/index.html 712 B -1 B (0%)
examples/demo/dist/alias-outside/index.html 692 B -1 B (0%)
examples/demo/dist/chunks/class-fields.********.js 210 B -4 B (-2%)
examples/demo/dist/chunks/index.********.js 304 B +103 B (+51%) 🆘
examples/demo/dist/chunks/meta-tags.********.js 298 B +2 B (+1%)
examples/demo/dist/chunks/prerender.********.js 293 B -2.14 kB (-88%) 🏆
examples/demo/dist/class-fields/index.html 703 B -1 B (0%)
examples/demo/dist/compat/index.html 1.54 kB -2 B (0%)
examples/demo/dist/env/index.html 778 B -1 B (0%)
examples/demo/dist/error/index.html 707 B -1 B (0%)
examples/demo/dist/files/index.html 738 B -1 B (0%)
examples/demo/dist/index.********.js 7.78 kB +6 B (0%)
examples/demo/dist/json/index.html 711 B -1 B (0%)
examples/demo/dist/lazy-and-late/index.html 713 B -1 B (0%)
examples/demo/dist/meta-tags/index.html 780 B +1 B (0%)
packages/wmr/wmr.cjs 767 kB +12.2 kB (+2%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/assets/Calendar.********.css 702 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 138 B
examples/demo/dist/chunks/compat.********.js 15.3 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/json.********.js 238 B
examples/demo/dist/index.html 770 B

compressed-size-action

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Sep 28, 2021

Currently the netlify build fails because we use node --experimental-modules and tsconfig-paths only has a CJS export, if we'd use the built wmr version we wouldn't have this issue 😅 it will be that or contributing back an esm export to tsconfig-paths. I guess for the tests it'd be best to contribute an ESM export

CC @developit @marvinhagemeister

@marvinhagemeister
Copy link
Member

Looks like the CI is failing because we're testing against an older Node 12.x release which doesn't include the backported commonjs<->esm interop stuff that newer 12.x releases have. Now with Node 14 being the official LTS I think we're way overdue to update to the newest 12.x release in our pipeline at minimum.

@JoviDeCroock
Copy link
Member Author

@marvinhagemeister updated in both netlify and the github workflow

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a bunch 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pick up aliases defined in compilerOptions.paths in tsconfig.json
2 participants