Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wmr) - resolve default over node #389

Merged
merged 18 commits into from
Mar 6, 2021
Merged

Conversation

JoviDeCroock
Copy link
Member

This is a test for #388

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2021

🦋 Changeset detected

Latest commit: d0f5fe8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock marked this pull request as draft March 1, 2021 19:44
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

Size Change: +353 B (0%)

Total Size: 690 kB

Filename Size Change
packages/wmr/wmr.cjs 657 kB +353 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/wmr/demo/dist/about/index.html 657 B 0 B
packages/wmr/demo/dist/assets/Calendar.********.css 702 B 0 B
packages/wmr/demo/dist/assets/style.********.css 386 B 0 B
packages/wmr/demo/dist/chunks/class-fields.********.js 200 B 0 B
packages/wmr/demo/dist/chunks/compat.********.js 15.3 kB 0 B
packages/wmr/demo/dist/chunks/index.********.js 199 B 0 B
packages/wmr/demo/dist/chunks/prerender.********.js 2.45 kB 0 B
packages/wmr/demo/dist/class-fields/index.html 635 B 0 B
packages/wmr/demo/dist/compat/index.html 1.49 kB 0 B
packages/wmr/demo/dist/env/index.html 713 B 0 B
packages/wmr/demo/dist/error/index.html 646 B 0 B
packages/wmr/demo/dist/files/index.html 675 B 0 B
packages/wmr/demo/dist/index.********.js 7.07 kB 0 B
packages/wmr/demo/dist/index.html 703 B 0 B
packages/wmr/demo/dist/lazy-and-late/index.html 657 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock marked this pull request as ready for review March 1, 2021 23:33
Copy link
Member

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit 🙃 – feel free to disregard though.
I think this looks good to me~!

packages/wmr/src/plugins/npm-plugin/resolve.js Outdated Show resolved Hide resolved
@marvinhagemeister marvinhagemeister merged commit fe51b7e into main Mar 6, 2021
@marvinhagemeister marvinhagemeister deleted the default-over-node branch March 6, 2021 07:33
@github-actions github-actions bot mentioned this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants