Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove impossible branch #4491

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Remove impossible branch #4491

merged 3 commits into from
Sep 13, 2024

Conversation

JoviDeCroock
Copy link
Member

Key can't exist in props as we hoist it to the VNode.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-6.74ms - +3.40ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.08ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +1% (-2.60ms - +1.02ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +4% (-0.14ms - +0.65ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +3% (-1.95ms - +2.53ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -8% - -0% (-0.17ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -4% - +2% (-1.32ms - +0.79ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-1.29ms - +1.12ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-0.57ms - +0.29ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local915.17ms - 920.34ms-unsure 🔍
-1% - +0%
-6.74ms - +3.40ms
preact-main915.06ms - 923.79msunsure 🔍
-0% - +1%
-3.40ms - +6.74ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.24ms - 25.24ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main25.25ms - 25.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.72ms-unsure 🔍
-0% - +1%
-0.08ms - +0.12ms
preact-main16.56ms - 16.65msunsure 🔍
-1% - +0%
-0.12ms - +0.08ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.63ms - 1.64ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main1.63ms - 1.64msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.02ms - 71.37ms-unsure 🔍
-4% - +1%
-2.60ms - +1.02ms
preact-main69.81ms - 73.17msunsure 🔍
-1% - +4%
-1.02ms - +2.60ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.72ms - 15.32ms-unsure 🔍
-4% - +2%
-0.57ms - +0.29ms
preact-main14.85ms - 15.47msunsure 🔍
-2% - +4%
-0.29ms - +0.57ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.95ms - 18.59ms-unsure 🔍
-1% - +4%
-0.14ms - +0.65ms
preact-main17.79ms - 18.24msunsure 🔍
-4% - +1%
-0.65ms - +0.14ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.54ms - 4.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.54ms - 4.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local77.93ms - 81.41ms-unsure 🔍
-2% - +3%
-1.95ms - +2.53ms
preact-main77.97ms - 80.79msunsure 🔍
-3% - +2%
-2.53ms - +1.95ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.56ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.54ms - 3.55msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.68ms - 31.31ms-unsure 🔍
-1% - +2%
-0.16ms - +0.73ms
preact-main30.40ms - 31.02msunsure 🔍
-2% - +1%
-0.73ms - +0.16ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.18ms - 36.46ms-unsure 🔍
-4% - +1%
-1.38ms - +0.41ms
preact-main35.68ms - 36.92msunsure 🔍
-1% - +4%
-0.41ms - +1.38ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.39ms - 26.81ms-unsure 🔍
-2% - +1%
-0.50ms - +0.14ms
preact-main26.54ms - 27.02msunsure 🔍
-1% - +2%
-0.14ms - +0.50ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local30.04ms - 32.03ms-unsure 🔍
-4% - +4%
-1.32ms - +1.29ms
preact-main30.21ms - 31.89msunsure 🔍
-4% - +4%
-1.29ms - +1.32ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.68ms - 21.14ms-unsure 🔍
-2% - +1%
-0.52ms - +0.13ms
preact-main20.87ms - 21.33msunsure 🔍
-1% - +2%
-0.13ms - +0.52ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local24.70ms - 26.13ms-unsure 🔍
-2% - +5%
-0.55ms - +1.31ms
preact-main24.44ms - 25.63msunsure 🔍
-5% - +2%
-1.31ms - +0.55ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.97ms - 2.08ms-unsure 🔍
-8% - -0%
-0.17ms - +0.00ms
preact-main2.05ms - 2.17msunsure 🔍
-0% - +8%
-0.00ms - +0.17ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.08ms - 1.08ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.07ms - 1.08msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.74ms - 36.00ms-unsure 🔍
-4% - +2%
-1.32ms - +0.79ms
preact-main34.79ms - 36.48msunsure 🔍
-2% - +4%
-0.79ms - +1.32ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.19ms - 1.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.19ms - 1.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.18ms - 34.02ms-unsure 🔍
-4% - +3%
-1.29ms - +1.12ms
preact-main32.41ms - 33.96msunsure 🔍
-3% - +4%
-1.12ms - +1.29ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.48ms - 3.49ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.48ms - 3.49msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Size Change: -137 B (-0.22%)

Total Size: 61.9 kB

Filename Size Change
dist/preact.js 4.64 kB -21 B (-0.45%)
dist/preact.min.js 4.67 kB -22 B (-0.47%)
dist/preact.min.module.js 4.67 kB -22 B (-0.47%)
dist/preact.min.umd.js 4.7 kB -23 B (-0.49%)
dist/preact.module.js 4.66 kB -25 B (-0.53%)
dist/preact.umd.js 4.71 kB -24 B (-0.51%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.11 kB
compat/dist/compat.module.js 4.04 kB
compat/dist/compat.umd.js 4.18 kB
debug/dist/debug.js 3.81 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.89 kB
devtools/dist/devtools.js 259 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Coverage Status

coverage: 99.487% (-0.001%) from 99.488%
when pulling 62e6fce on golf-unused
into 022dbb1 on main.

@JoviDeCroock JoviDeCroock merged commit 0943ac7 into main Sep 13, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the golf-unused branch September 13, 2024 10:05
@JoviDeCroock JoviDeCroock mentioned this pull request Sep 14, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Oct 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Closed
@abaum65 abaum65 mentioned this pull request Oct 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @marvinhagemeister