Bail a bit later

preactjs · Sep 12, 2024 · f02066b · f02066b
1 parent 0453daa
commit f02066b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/diff/index.js b/src/diff/index.js
@@ -523,7 +523,7 @@ function diffElementNodes(
 			// Remove children that are not part of any vnode.
 			if (excessDomChildren != null) {
 				for (i = excessDomChildren.length; i--; ) {
-					if (excessDomChildren[i] != null) removeNode(excessDomChildren[i]);
+					removeNode(excessDomChildren[i]);
 				}
 			}
 		}
@@ -625,7 +625,7 @@ export function unmount(vnode, parentVNode, skipRemove) {
 		}
 	}
 
-	if (!skipRemove && vnode._dom != null) {
+	if (!skipRemove) {
 		removeNode(vnode._dom);
 	}
 

diff --git a/src/util.js b/src/util.js
@@ -22,8 +22,10 @@ export function assign(obj, props) {
  * @param {preact.ContainerNode} node The node to remove
  */
 export function removeNode(node) {
-	let parentNode = node.parentNode;
-	if (parentNode) parentNode.removeChild(node);
+	if (node) {
+		let parentNode = node.parentNode;
+		if (parentNode) parentNode.removeChild(node);
+	}
 }
 
 export const slice = EMPTY_ARR.slice;