Simple suspense renderer 2024 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf81587 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
force-pushed
the
simple-suspense-renderer-2024
branch
from
caf816a
to
5fbe601
Compare
JoviDeCroock
commented
Feb 8, 2024
marvinhagemeister
approved these changes
Feb 19, 2024
Merged
rschristian
reviewed
Mar 18, 2024
Comment on lines
+67
to
+69
| if (e.then) { | ||
| throw new Error('Use "renderToStringAsync" for suspenseful rendering.'); | ||
| } |
There was a problem hiding this comment.
Only just noticed, this is a breaking change for all preact-iso users... do we want to downgrade this to a warning message instead of throwing an error, or just accept the breaking change in a minor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #303