Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .inl extension #273

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add .inl extension #273

merged 1 commit into from
Jan 27, 2022

Conversation

PointKernel
Copy link
Contributor

@PointKernel PointKernel commented Jan 26, 2022 •
edited
Loading

This PR adds .inl as a c++ file extension.

@asottile
Copy link
Member

this should be two separate PRs

@asottile
Copy link
Member

can you provide a reference for this?

@PointKernel
Copy link
Contributor Author

I haven't found any solid references yet but using .inl headers is a common practice to separate template/inline interface from implementation in c++ headers. Here are some links you may find useful:

  1. Stackoverflow discussion on "Significance of a .inl file in C++"
  2. INL file definition from fileinfo.com

asottile
asottile reviewed Jan 27, 2022
View reviewed changes
identify/extensions.py Outdated Show resolved Hide resolved
asottile
asottile approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit d47beda into pre-commit:master Jan 27, 2022
@PointKernel PointKernel mentioned this pull request Jan 27, 2022
Merged
@PointKernel PointKernel mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @asottile