Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watch replay button sometimes not loading the replay on first click #30895

Merged
merged 1 commit into from
Nov 28, 2024

Use `RealmLive` in `SaveFailedScoreButton`

5260a40
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix watch replay button sometimes not loading the replay on first click #30895

Use `RealmLive` in `SaveFailedScoreButton`
5260a40
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Nov 27, 2024 in 0s

42987 passed, 1 failed and 296 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 10747✅ 74⚪ 2284s
TestResults-Linux-SingleThread.trx 10747✅ 74⚪ 1942s
TestResults-Windows-MultiThreaded.trx 10746✅ 1❌ 74⚪ 2913s
TestResults-Windows-SingleThread.trx 10747✅ 74⚪ 2720s

✅ TestResults-Linux-MultiThreaded.trx

10821 tests were completed in 2284s with 10747 passed, 0 failed and 74 skipped.

✅ TestResults-Linux-SingleThread.trx

10821 tests were completed in 1942s with 10747 passed, 0 failed and 74 skipped.

❌ TestResults-Windows-MultiThreaded.trx

10821 tests were completed in 2913s with 10746 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback 3✅ 1❌ 4s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback

✅ TestAllSamplesStopDuringSeek
❌ TestAllSamplesStopDuringSeek
	sample playback still disabled
✅ TestConstructor
✅ TestConstructor

✅ TestResults-Windows-SingleThread.trx

10821 tests were completed in 2720s with 10747 passed, 0 failed and 74 skipped.

Annotations

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback ► TestAllSamplesStopDuringSeek

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  sample playback still disabled
Raw output
sample playback still disabled
   at osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback.TestAllSamplesStopDuringSeek() in D:\a\osu\osu\osu.Game.Tests\Visual\Gameplay\TestSceneGameplaySamplePlayback.cs:line 58