Fix watch replay button sometimes not loading the replay on first click #30895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also optimises the manager classes to better support `Live` usage where the managed object is already in a good state (ie. doesn't require re-fetching).
bdach
approved these changes
Nov 28, 2024
Comment on lines
+562
to
+566
| if (beatmapInfo.IsManaged) | ||
| { | ||
| beatmapInfo = beatmapInfo.Detach(); | ||
| } | ||
| else if (refetch || missingFiles) |
There was a problem hiding this comment.
This change makes me nervous but I don't have any concrete reason to doubt it so I'm just gonna hope this breaks nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28497.
Note that this will force a refresh delay in the previous fail case, via
osu/osu.Game/Database/RealmLive.cs
Lines 65 to 66 in 6e11162
This is intentional – refresh is sometimes required and using
RealmLiveensures it happens if and only if required. The blocking operation time is reduced drastically with #30893 to the point that makes it hard to trigger this bug anymore with the provided database.