Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily challenge results screen fetching scores beginning from the user's highest #30852

Merged
merged 8 commits into from
Nov 28, 2024

Merge branch 'master' into fix-daily-challenge-leaderboard

0d491e3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix daily challenge results screen fetching scores beginning from the user's highest #30852

Merge branch 'master' into fix-daily-challenge-leaderboard
0d491e3
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Nov 28, 2024 in 0s

43003 passed, 1 failed and 296 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 10751✅ 74⚪ 2311s
TestResults-Linux-SingleThread.trx 10751✅ 74⚪ 1960s
TestResults-Windows-MultiThreaded.trx 10750✅ 1❌ 74⚪ 2910s
TestResults-Windows-SingleThread.trx 10751✅ 74⚪ 2737s

✅ TestResults-Linux-MultiThreaded.trx

10825 tests were completed in 2311s with 10751 passed, 0 failed and 74 skipped.

✅ TestResults-Linux-SingleThread.trx

10825 tests were completed in 1960s with 10751 passed, 0 failed and 74 skipped.

❌ TestResults-Windows-MultiThreaded.trx

10825 tests were completed in 2910s with 10750 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen 43✅ 1❌ 48s

❌ osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen

✅ TestAudioLeadIn
✅ TestAudioLeadIn
✅ TestConstructor
✅ TestConstructor
✅ TestDelayedStart
✅ TestDelayedStart
✅ TestGameplayRateAdjust
✅ TestGameplayRateAdjust
✅ TestGeneral(1)
✅ TestGeneral(1)
✅ TestGeneral(4)
✅ TestGeneral(4)
✅ TestGeneral(9)
✅ TestGeneral(9)
✅ TestIntroStoryboardElement
✅ TestIntroStoryboardElement
✅ TestMostInSyncUserIsAudioSource
❌ TestMostInSyncUserIsAudioSource
	assertOnePlayerNotMuted
✅ TestMultipleStartRequests
✅ TestMultipleStartRequests
✅ TestPlayersCatchUpAfterFallingBehind
✅ TestPlayersCatchUpAfterFallingBehind
✅ TestPlayersContinueWhileOthersBuffer
✅ TestPlayersContinueWhileOthersBuffer
✅ TestPlayersDoNotStartSimultaneouslyIfBufferingForMaximumStartDelay
✅ TestPlayersDoNotStartSimultaneouslyIfBufferingForMaximumStartDelay
✅ TestPlayersLeaveWhileSpectating
✅ TestPlayersLeaveWhileSpectating
✅ TestPlayersMustStartSimultaneously
✅ TestPlayersMustStartSimultaneously
✅ TestSpectatingDuringGameplay
✅ TestSpectatingDuringGameplay
✅ TestSpectatingDuringGameplayWithLateFrames
✅ TestSpectatingDuringGameplayWithLateFrames
✅ TestSpectatorPlayerInteractiveElementsHidden
✅ TestSpectatorPlayerInteractiveElementsHidden
✅ TestTeamDisplay
✅ TestTeamDisplay
✅ TestTeams(16)
✅ TestTeams(16)
✅ TestTeams(2)
✅ TestTeams(2)
✅ TestTimeDoesNotProgressWhileAllPlayersPaused
✅ TestTimeDoesNotProgressWhileAllPlayersPaused

✅ TestResults-Windows-SingleThread.trx

10825 tests were completed in 2737s with 10751 passed, 0 failed and 74 skipped.

Annotations

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen ► TestMostInSyncUserIsAudioSource 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  assertOnePlayerNotMuted
Raw output 
assertOnePlayerNotMuted
   at osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen.assertOnePlayerNotMuted() in D:\a\osu\osu\osu.Game.Tests\Visual\Multiplayer\TestSceneMultiSpectatorScreen.cs:line 532
   at osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen.TestMostInSyncUserIsAudioSource() in D:\a\osu\osu\osu.Game.Tests\Visual\Multiplayer\TestSceneMultiSpectatorScreen.cs:line 316
View more details on GitHub Actions