Fix daily challenge results screen fetching scores beginning from the user's highest

[frenzibyte]

• Closes Daily Challenge results start loading from personal best on subsequent scores #29240

Note that using the scoreid-based endpoint for fetching scores excludes the user's highest score for some reason, this can be seen in the video below as my highest score with total score 118,509 is omitted from the results screen. It's sort of a minor detail to care about so I'm not considering it a blocker for this p:0 issue.

Video snippet of testing the new code on dev server:

CleanShot.2024-11-23.at.15.42.14.mp4

[bdach]

This made more sense in playlists where the results screen shows the average scores of all players

That's... not how it works? In playlists the results screen shows everyone's best score on the particular playlist item. You're confusing that with the leaderboard on the playlists lounge, which shows the sum of best plays across all playlist items, not the average. Nothing ever shows the average. I dunno where it would ever make sense to show an "average score".

In light of that I question the entire premise of this pull request in that it's doing something special to daily challenge. What's the guarantee that this doesn't happen on standard playlists? From testing on production (with a release build) I'm pretty sure this will not be a problem that is unique to daily challenge.

What I believe to be happening here is that the request fetches the user's best score on the playlist, while the results screen shows the completed play, and there's a gap of missing scores in between, so the automatic page fetch logic attempts to load every available score between user's best and current to fill the gap. And if that is the case then this is only monkey patching the issue in daily challenge, without fixing the same issue in playlists, for no reason whatsoever.

[frenzibyte]

I used the wrong word, I meant the sum not the average, you could have assumed that part.

What I believe to be happening here is that the request fetches the user's best score on the playlist, while the results screen shows the completed play, and there's a gap of missing scores in between, so the automatic page fetch logic attempts to load every available score between user's best and current to fill the gap.

I will assume you're not implying that I should've stated this in the PR description, this part should be clear by the title alone.

And if that is the case then this is only monkey patching the issue in daily challenge, without fixing the same issue in playlists, for no reason whatsoever.

Well hey then I am utterly confused about why are we even using the ShowPlaylistUserScoreRequest endpoint at all.

[bdach]

Well hey then I am utterly confused about why are we even using the ShowPlaylistUserScoreRequest endpoint at all.

This bug has probably been in playlists all these years but nobody either noticed or bothered to report it. The other request that takes in a score ID was added for daily challenge specifically.

[bdach]

Not sure how this happened but test failures in the test that was specifically adjusted here

[frenzibyte]

My bad, I rushed out a push yesterday without double-checking tests.

[frenzibyte]

Fixed test failure and also took some time to rethink the PlaylistItemResultsScreen structure to make more sense with the changes applied to the endpoint. Tested to work correctly on all of playlists, multiplayer, and daily challenge.

[bdach]

seems fine, even for the code quality improvement aspect of it (no more weird nullable score ctor params)