Fix timing point truncation causing missnaps on compatibility-exported lazer beatmaps #30607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Nov 14, 2024
| namespace osu.Game.Tests.Beatmaps.IO | ||
| { | ||
| [HeadlessTest] | ||
| public partial class LegacyBeatmapExporterTest : OsuTestScene |
There was a problem hiding this comment.
Just wondering if this test would be better suited to the LegacyBeatmapEncoderTest class?
There was a problem hiding this comment.
I'd actually prefer them to be here. Encoder shouldn't be caring about backcompat logic, encoder should be encoding, i.e. dumb formatting logic. This same location is where I'd also put legacy export stability tests that you asked for in relation to BSS and which we don't currently have.
bdach
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30606