-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make quick restart even faster #30603
Conversation
Tests need attention. |
I think we're gonna include this in the release tomorrow because it makes sense (this was already changed once in the release but this makes it better, so rather than splitting over two releases and having people disappointed that the first change wasn't powerful enough, let's expedite this one in). |
Um... this feels absurdly jarring to me? 2024-11-14.08-47-39.mp4Like yes, I guess it's faster, but it also feels like the metadata display is trying to jumpscare me by being on screen for like 5 frames. Maybe it should be gone too? Or at least delayed enough so that it only shows when there's actually a substantial load time? |
Sure, I'll delay its display for now. |
@bdach please give it another try. I've made it halfway between what stable used to do (remain at black) but with what I hope feels like a nice touch. Also please test quick retrying about 20 times in a row. I am getting a flash of the black disappearing during what I believe do the the fade out in player, but I believe that's macOS vsync doing weird things and not a game level bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, visually seems much better. Couldn't find any fault with it on a few maps.
Also please test quick retrying about 20 times in a row. I am getting a flash of the black disappearing during what I believe do the the fade out in player, but I believe that's macOS vsync doing weird things and not a game level bug.
Not seeing anything of the sort here.
Co-authored-by: Bartłomiej Dach <[email protected]>
Closes #27480. |
This is a second pass at refining the quick restart experience.