Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quick restart even faster #30603

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 13, 2024

This is a second pass at refining the quick restart experience.

  • More arbitrarily induced delays are culled
  • Settings are hidden now (since interacting with them is nigh impossible given the faster restart speed)
  • Some animations are hidden to make the process less jarring
  • Parallax is disabled to stop the background displacing weirdly

@smoogipoo
Copy link
Contributor

Tests need attention.

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Nov 14, 2024
@peppy
Copy link
Member Author

peppy commented Nov 14, 2024

I think we're gonna include this in the release tomorrow because it makes sense (this was already changed once in the release but this makes it better, so rather than splitting over two releases and having people disappointed that the first change wasn't powerful enough, let's expedite this one in).

@peppy peppy requested a review from a team November 14, 2024 04:15
@bdach bdach self-requested a review November 14, 2024 07:38
@bdach
Copy link
Collaborator

bdach commented Nov 14, 2024

Um... this feels absurdly jarring to me?

2024-11-14.08-47-39.mp4

Like yes, I guess it's faster, but it also feels like the metadata display is trying to jumpscare me by being on screen for like 5 frames. Maybe it should be gone too? Or at least delayed enough so that it only shows when there's actually a substantial load time?

@peppy
Copy link
Member Author

peppy commented Nov 14, 2024

Sure, I'll delay its display for now.

@pull-request-size pull-request-size bot added size/L and removed size/S labels Nov 14, 2024
@peppy
Copy link
Member Author

peppy commented Nov 14, 2024

@bdach please give it another try. I've made it halfway between what stable used to do (remain at black) but with what I hope feels like a nice touch.

Also please test quick retrying about 20 times in a row. I am getting a flash of the black disappearing during what I believe do the the fade out in player, but I believe that's macOS vsync doing weird things and not a game level bug.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, visually seems much better. Couldn't find any fault with it on a few maps.

Also please test quick retrying about 20 times in a row. I am getting a flash of the black disappearing during what I believe do the the fade out in player, but I believe that's macOS vsync doing weird things and not a game level bug.

Not seeing anything of the sort here.

osu.Game/Screens/Play/PlayerLoader.cs Outdated Show resolved Hide resolved
osu.Game/Screens/Play/PlayerLoader.cs Show resolved Hide resolved
Co-authored-by: Bartłomiej Dach <[email protected]>
@bdach bdach merged commit 1355fa6 into ppy:master Nov 14, 2024
8 of 10 checks passed
@Loreos7
Copy link
Contributor

Loreos7 commented Nov 14, 2024

Closes #27480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L type:behavioural
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants