-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick retry should be instant, it shouldn't reload the entire beatmap #9039
Comments
There's two ways to look at this. First of all we do have an eventual plan of caching the post-parsed beatmap content in Second is that a quick restart only needs to rewind to the beginning of the beatmap, and we may be able to do this in a fun way using existing rewind logic. Unfortunately rewind logic is also under-performant current and this would likely take longer (unless near the beginning of the map) currently. Both relatively low priority but definite considerations we have in mind that will help with the mentioned restart case. |
This have vastly been improved with the introduction of pooling. Going to drop this to low priority. |
For me this is a big deal, retry in osu! standard is absolutely instant. But in lazer it absolutely gets me out of the zone/ flow state. |
why is this low priority this is one of the most asked for features by the player base ? please give quicker retry |
Should help with ppy#9039.
Will be improved in the next release. Please report back on how things feel. |
@peppy I'm not sure if it's the intended effect, but it feels inconsistent. untitled.mp4I'm on linux, with osu-lazer version 2024.1115.3 |
that's probably because if you don't hit anything, the score doesn't submit. aborted plays where something was hit do submit to the server, not for the purposes of leaderboard display of actual score keeping, but for the purposes of profile statistics accounting. |
Okay, makes sense. But the display of the title\loading screen is still jarring compared to the previous version. Is this just something on my system? |
The beatmap info only shows if the loading takes enough time. This change was made here: #30603 (comment) |
So.. It would look jarring either way, whether it loads fast or a 500ms too late. I'd honestly much prefer having it hidden altogether on quick retry, unless it takes absurdly long time to load, indicating a problem of some sort. |
It just occurred to me to test it out when I'm not logged in. There's no delay, so the info isn't displayed (as expected). Quick retry feels almost instant, and I think it's actually faster than being logged in. I believe the culprit in my case is the network. Having some network activity is apparently causing me a bit of delay, exceeding the threshold of fading-in the beatmap's metadata, and potentially delaying quick retry. Edit: I've also tested being logged in, failing on a beatmap and waiting for a bit before hitting the quick retry button. Info isn't displayed as expected, and retrying feels faster. Exactly the same as being logged out. |
Eventually the score submit will become async and stop slowing down retry. Closing this issue thread as it's now implemented. |
Describe the bug:
When restarting the map (via quick retry hotkey) everything is reset and reloaded which can take a very long time on low spec computers or on maps with elaborate storyboards. Instead of restarting the entire map, only score (and replay recording, etc.) should reset and song should be seeked to the beginning, everything else that stays the same between runs (hitobjects, storyboard assets) shouldn't be reloaded.
osu!lazer version:
2020.515.0
The text was updated successfully, but these errors were encountered: