Highlight maximum combo and accuracy on user best score display to match web #30346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezwery
changed the title
Nobody is supposed to be using `ColourInfo` directly, really.
bdach
previously approved these changes
Oct 21, 2024
Comment on lines
+107
to
+109
| #pragma warning disable CS0618 | ||
| if (score.MaxCombo == score.BeatmapInfo!.MaxCombo) maxComboColumn.TextColour = colours.GreenLight; | ||
| #pragma warning restore CS0618 |
There was a problem hiding this comment.
The only reason I'm letting this deprecation bypass slide is that the other current usage of this is in essentially the same place, i.e. ScoreTable.
If this were to be used literally anywhere else I'd close the PR on the spot with no discussion.
bdach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #30342