Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perfect combo and accuracy aren't highlighted in DrawableTopScore #30342

Closed
424ever opened this issue Oct 18, 2024 · 2 comments
Closed

Perfect combo and accuracy aren't highlighted in DrawableTopScore #30342

424ever opened this issue Oct 18, 2024 · 2 comments
Labels
area:overlay-beatmap good first issue A good place to start contributing to this project without going too deep. type:cosmetic

Comments

@424ever
Copy link
Contributor

424ever commented Oct 18, 2024

Type

Cosmetic

Bug description

On the website, a perfect combo and 100% accuracy are highlighted in green in the section showing the personal best and number 1 score on a beatmap (the same way they are highlighted in the score table). This is not the case in-game.

Screenshots or videos

website
firefox_fEHsRRXVEm

lazer
osu_2024-10-18_21-06-40

Version

2024.1009.1

Logs

compressed-logs.zip
@TaterToes
Copy link
Contributor

Personally, I do think it should be highlighted in game, but I will wait to see if others disagree

@Joehuu Joehuu added type:cosmetic good first issue A good place to start contributing to this project without going too deep. area:overlay-beatmap labels Oct 18, 2024
@wezwery wezwery mentioned this issue Oct 19, 2024
Merged
@Joehuu
Copy link
Member

Joehuu commented Oct 21, 2024

Implemented in #30346.

@Joehuu Joehuu closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:overlay-beatmap good first issue A good place to start contributing to this project without going too deep. type:cosmetic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Joehuu @424ever @TaterToes