Remove default keybind for "Toggle FPS counter" #30264
Conversation
|
Just set it to have no default. Please let's not try and rationalise absolutely arbitrary keys. It's not worth it. |
LBlend
changed the title
|
This doesn't do anything to fix the issue for users whose databases have already been populated with default keybindings as they will continue to be bound to the conflicting keybind...? I'm not sure why this was deemed the correct course of action in light of that, it feels as much of a cop-out solution as #30252 did. |
I guess we could also unbind it for the case it's set to the default? I'm not interested in fixing it for new installs or when a user resets bindings. I can't think of another game existing with a hotkey for fps display, so I don't think osu! should have it. |
That is what we've historically done for hotkey conflicts, but it will require a realm migration to be included here. |
osu.Game/Database/RealmAccess.cs
Outdated
| var keyBindings = migration.NewRealm.All<RealmKeyBinding>(); | ||
|
|
||
| var toggleFpsBind = keyBindings.FirstOrDefault(bind => bind.ActionInt == (int)GlobalAction.ToggleFPSDisplay); | ||
| if (toggleFpsBind != null && toggleFpsBind.KeyCombination.Keys.SequenceEqual(new[] { InputKey.Control, InputKey.Shift, InputKey.F })) |
There was a problem hiding this comment.
Was this tested at all? The .SequenceEqual() here didn't work and should have been
| if (toggleFpsBind != null && toggleFpsBind.KeyCombination.Keys.SequenceEqual(new[] { InputKey.Control, InputKey.Shift, InputKey.F })) | |
| if (toggleFpsBind != null && toggleFpsBind.KeyCombination.Keys.SequenceEqual(new[] { InputKey.Shift, InputKey.Control, InputKey.F })) |
I've fixed it (f8a13b0) but really this should not have gone through if this code was tested.
Closes #30169
Referring to #30252.
As per peppy's suggestion I changed the keybind for toggling the FPS counter. As per peppy's new suggestion I removed the default keybind for toggling the FPS counter. This is done in order to avoid conflicts with the keybind for converting a slider to a stream in the editor.Why Ctrl-Alt-C?Ctrl-Shift-Cis copying without formattingSame goes forCtrl-Shift-XCtrl-Alt-Fis used to fullscreen windows in certain desktop environmentsThe other combinations that are in reach are in use by the gameCtrl-Alt-Cholds some semantic meaning in the sense that "C" is short for "counter".