Update shader preloader with missing shader usages #30018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Sep 27, 2024
osu.Game/Screens/Loader.cs
Outdated
Comment on lines
121
to
134
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, FragmentShaderDescriptor.TEXTURE)); | ||
|
|
||
| loadTargets.Add(manager.Load(@"CursorTrail", FragmentShaderDescriptor.TEXTURE)); | ||
|
|
||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, "TriangleBorder")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, "FastCircle")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"TriangleBorder")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"FastCircle")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"CircularProgress")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"ArgonBarPath")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"ArgonBarPathBackground")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"SaturationSelectorBackground")); | ||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, @"HueSelectorBackground")); | ||
|
|
||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_3, FragmentShaderDescriptor.TEXTURE)); | ||
|
|
||
| loadTargets.Add(manager.Load(@"CursorTrail", FragmentShaderDescriptor.TEXTURE)); | ||
| loadTargets.Add(manager.Load(@"LogoAnimation", @"LogoAnimation")); |
There was a problem hiding this comment.
Not sure if oversight or intentionally skipped, but there's also this one:
There was a problem hiding this comment.
Hmm, this is in a ruleset implementation so I'm not 100% sure, but let's add it for now.
smoogipoo
requested changes
Sep 27, 2024
osu.Game/Screens/Loader.cs
Outdated
| @@ -118,13 +118,21 @@ private void load(ShaderManager manager) | |||
| { | |||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, FragmentShaderDescriptor.TEXTURE)); | |||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, FragmentShaderDescriptor.BLUR)); | |||
| loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_2, FragmentShaderDescriptor.TEXTURE)); | |||
There was a problem hiding this comment.
This one looks to be a duplicate
peppy
force-pushed
the
add-missing-shader-preload
branch
from
1683f72 to
82c2123
Compare
peppy
force-pushed
the
add-missing-shader-preload
branch
from
82c2123 to
5be63ee
Compare
smoogipoo
approved these changes
Sep 27, 2024
bdach
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed stutter on first load of #29936.