Fix daily challenge stats display suffix not displayed #29405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
force-pushed
the
fix-daily-challenge
branch
from
3b0aeb7 to
d109ccd
Compare
smoogipoo
reviewed
Aug 13, 2024
Comment on lines
+115
to
+116
| // todo: ideally we want to use UsersStrings.ShowDailyChallengeUnit{Day,Week}(...), but it's broken right now. | ||
| // see: https://github.com/ppy/osu/issues/29355#issuecomment-2277139889 |
There was a problem hiding this comment.
I don't think this is ever getting fixed 😅
smoogipoo
requested changes
Aug 13, 2024
Comment on lines
-118
to
+120
| currentWeekly.Value = UsersStrings.ShowDailyChallengeUnitWeek(statistics.WeeklyStreakCurrent.ToLocalisableString(@"N0")); | ||
| currentWeekly.Value = LocalisableString.Interpolate($"{statistics.WeeklyStreakCurrent.ToLocalisableString(@"N0")}w"); |
There was a problem hiding this comment.
We should add concrete localisations for these instead imo. Duplicate the osu!web ones for our purpose.
There was a problem hiding this comment.
Feel free to apply that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost forgot to fix this one before release. The new code may be a little too complicated, it just tries to preserve localisation of the number itself while arbitrarily adding "d"/"w" at the end. We can remove localisation from the number itself and simplify further but I think this is fine as-is.